[coreboot-gerrit] Patch merged into coreboot/master: intel/sandybridge: Do not guard native VGA init by #ifdefs

gerrit at coreboot.org gerrit at coreboot.org
Mon Sep 7 23:51:28 CET 2015


the following patch was just integrated into master:
commit 9647094672eb2ea31c6192de92028614164b9d9c
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Mon Sep 7 03:06:31 2015 -0700

    intel/sandybridge: Do not guard native VGA init by #ifdefs
    
    We don't build-test with native VGA init, so if the code is broken by
    a commit, we won't see it when it's guarded by #ifdefs. This has
    already happened in the past. Instead of gurading entire files, use
    the IS_ENABLED() macro, and return early. This at least enables us to
    build-test the code to some extent, while linker garbage collection
    will removed unused parts.
    
    BONUS: Indenting some blocks also makes the difference between
    framebuffer init and textmode init clearer.
    
    Change-Id: I334cdee214872f967ae090170d61a0e4951c6b35
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
    Reviewed-on: http://review.coreboot.org/11586
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See http://review.coreboot.org/11586 for details.

-gerrit



More information about the coreboot-gerrit mailing list