[coreboot-gerrit] Patch merged into coreboot/master: skylake: refactor flash_controller code
gerrit at coreboot.org
gerrit at coreboot.org
Tue Sep 8 11:30:17 CET 2015
the following patch was just integrated into master:
commit 11f356c3904321838d69e31f6de3a7fad9d8f42d
Author: Aaron Durbin <adurbin at chromium.org>
Date: Thu Aug 27 14:30:22 2015 -0500
skylake: refactor flash_controller code
There's no need to add any typedefs nor guard code with
ENV_ROMSTAGE. The linker will garbage collect unused functions.
Additionally there were a few errors in the code including
the operation mask wasn't wide enough to clear out old operations
as well as component size decoding was incorrect.
The big difference in the code flow is that the operation
setup is now in one place. The stopwatch API is also used in
order to not open code time calculations.
BUG=chrome-os-partner:42115
BUG=chrome-os-partner:43522
BRANCH=None
TEST=Built and booted. Suspended and resumed. event log is populated
for all.
Change-Id: I0ddd42f0744cf8f88da832d7d715663238209a71
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: 9893fe309104c05edfb158afda6bb029801c0489
Original-Change-Id: I6468f5b9b4a73885b69ebd916861dd2e8e3746b6
Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/295980
Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
Reviewed-on: http://review.coreboot.org/11543
Tested-by: build bot (Jenkins)
Reviewed-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
See http://review.coreboot.org/11543 for details.
-gerrit
More information about the coreboot-gerrit
mailing list