[coreboot-gerrit] Patch set updated for coreboot: Makefile: Replace the way to test if a string is empty

[Zheng Bao (zheng.bao@amd.com)]

Zheng Bao (zheng.bao at amd.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11600

-gerrit

commit df9dc6bfcc5be4ff373969bec9922c5184f6327c
Author: zbao <fishbaozi at gmail.com>
Date:   Fri Sep 11 08:49:38 2015 -0400

    Makefile: Replace the way to test if a string is empty
    
    The output of command below,
    # i386-elf-nm build/cbfs/fallback/romstage_null.offenders | \
                         grep -q "" ; echo $?
    has different result on MacOS, OS X Mavericks, which outputs 0.
    On linux, it outputs 1.
    
    I assume it is misleading to search an empty string in a empty
    string. Change it to testing if the string is empty.
    
    Change-Id: Ie4b8fe1fb26df092e2985937251a49feadc61eb0
    Signed-off-by: Zheng Bao <zheng.bao at amd.com>
    Signed-off-by: Zheng Bao <fishbaozi at gmail.com>
---
 src/arch/x86/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index 68ed810..8bef5e6 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -183,7 +183,7 @@ $(objcbfs)/romstage_null.debug: $$(romstage-objs) $(objgenerated)/romstage_null.
 	$(LD_romstage) $(LDFLAGS_romstage) -o $@ -L$(obj) $(COMPILER_RT_FLAGS_romstage) --whole-archive --start-group $(filter-out %.ld,$(romstage-objs)) $(romstage-libs) --no-whole-archive $(COMPILER_RT_romstage) --end-group -T $(objgenerated)/romstage_null.ld --oformat $(romstage-oformat)
 	LANG=C LC_ALL= $(OBJCOPY_romstage) --only-section .illegal_globals $(@) $(objcbfs)/romstage_null.offenders 2>&1 | \
 	grep -v "Empty loadable segment detected" && \
-	$(NM_romstage) $(objcbfs)/romstage_null.offenders | grep -q ""; if [ $$? -eq 0 ]; then \
+	if [ -n "`$(NM_romstage) $(objcbfs)/romstage_null.offenders 2>/dev/null`" ]; then \
 		echo "Forbidden global variables in romstage:"; \
 		$(NM_romstage) $(objcbfs)/romstage_null.offenders; false; \
 		else true; fi