[coreboot-gerrit] Patch merged into coreboot/master: vbnv: check alignment of nvram in advance
gerrit at coreboot.org
gerrit at coreboot.org
Thu Sep 17 14:15:03 CET 2015
the following patch was just integrated into master:
commit 914a21ed9ceb403b178c30bedbc354e816b98e92
Author: Daisuke Nojiri <dnojiri at chromium.org>
Date: Fri Sep 4 14:32:49 2015 -0700
vbnv: check alignment of nvram in advance
Currently, erase operation only works if the region is sector-aligned.
These asserts ensure we can erase the region when it's all used up.
Erase operation can be updated to handle unaligned erases by read,
update, write-back cycle. However, these asserts will still remain useful
in case the adjacent region contains critical data and mis-updating it
can cause a critical failure.
Additionaly we should write a FAFT test but it's more reliable to catch
it here since FAFT can fail in many ways.
BUG=none
BRANCH=master
TEST=tested on samus using misaligned nvram region
Change-Id: I3add4671ed354d9763e21bf96616c8aeca0cb777
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: fc001a4d3446cf96b76367dde492c3453aa948c6
Original-Change-Id: Ib4df8f620bf7531b345364fa4c3e274aba09f677
Original-Signed-off-by: Daisuke Nojiri <dnojiri at chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/297801
Reviewed-on: http://review.coreboot.org/11654
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
See http://review.coreboot.org/11654 for details.
-gerrit
More information about the coreboot-gerrit
mailing list