[coreboot-gerrit] New patch to review for coreboot: ec: superio: Report keyboard IRQ as wake capable
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Fri Sep 25 14:38:36 CET 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11712
-gerrit
commit 5a598e2bdb90a95047dced0fd84af35503525f8b
Author: Duncan Laurie <dlaurie at chromium.org>
Date: Mon Sep 21 15:00:20 2015 -0700
ec: superio: Report keyboard IRQ as wake capable
In order to wake from S0ix the kernel needs to know that the
keyboard interrupt is wake capable. Using IRQNoFlags does not
allow the wake capability to be reported.
For normal S3 this does not matter as the EC is the one handling
the keyboard wake event. For S0ix the EC does not need to be
involved in this particular wake event.
BUG=chrome-os-partner:43079
BRANCH=none
TEST=echo freeze > /sys/power/state and wake from keyboard
Change-Id: I7175d2ea98f8a671765897de295df7b933151fc4
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: 645f1cd96c35f42aa7c40ff473b15feb619b0373
Original-Change-Id: Ia89c30c51be9db7b814b81261463d938885325fd
Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/301441
Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
src/ec/google/chromeec/acpi/superio.asl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl
index 39e60a3..b27f6d6 100644
--- a/src/ec/google/chromeec/acpi/superio.asl
+++ b/src/ec/google/chromeec/acpi/superio.asl
@@ -155,7 +155,7 @@ Device (SIO) {
#ifdef SIO_EC_PS2K_IRQ
SIO_EC_PS2K_IRQ
#else
- IRQNoFlags () {1}
+ IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1}
#endif
})
@@ -167,7 +167,7 @@ Device (SIO) {
#ifdef SIO_EC_PS2K_IRQ
SIO_EC_PS2K_IRQ
#else
- IRQNoFlags () {1}
+ IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1}
#endif
}
EndDependentFn ()
More information about the coreboot-gerrit
mailing list