[coreboot-gerrit] Patch merged into coreboot/master: i2c/w83795: Fix chip type message

gerrit at coreboot.org gerrit at coreboot.org
Tue Aug 2 14:03:07 CEST 2016


the following patch was just integrated into master:
commit 48e0792e4ae8d4267dc2d5fb6af3b2c079a4f61f
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Mon Aug 1 15:56:09 2016 +0200

    i2c/w83795: Fix chip type message
    
    (val & 4) == 1 is always false. Since val & 4 is either zero or
    non-zero, just drop the second test (for "== 1").
    Validated against the data sheet that this is really the right register,
    bit and value.
    
    Change-Id: I627df9a9b4fddfff486689e405f52a3b54135eef
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1241864
    Reviewed-on: https://review.coreboot.org/16009
    Tested-by: build bot (Jenkins)
    Reviewed-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>


See https://review.coreboot.org/16009 for details.

-gerrit



More information about the coreboot-gerrit mailing list