[coreboot-gerrit] New patch to review for coreboot: soc/intel/quark: Add missing breaks

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Fri Aug 5 15:28:22 CEST 2016


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16069

-gerrit

commit 271ddd45a464d68bcc5ac2de7e3a86fbcf8f74e4
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Fri Aug 5 06:11:19 2016 -0700

    soc/intel/quark: Add missing breaks
    
    Add missing breaks in reg_access.c.
    
    TEST=Build and run on Galileo Gen2
    
    Found-by: Converity Scan #1361261
    
    Change-Id: I8be57f0758e5918a605e20ab9002747e0cc958e0
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/quark/reg_access.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/soc/intel/quark/reg_access.c b/src/soc/intel/quark/reg_access.c
index 3d530b9..2ddb99b 100644
--- a/src/soc/intel/quark/reg_access.c
+++ b/src/soc/intel/quark/reg_access.c
@@ -163,9 +163,11 @@ static void reg_cpu_cr_write(uint32_t reg_address, CRx_TYPE value)
 
 	case 0:
 		write_cr0(value);
+		break;
 
 	case 4:
 		write_cr4(value);
+		break;
 	}
 }
 



More information about the coreboot-gerrit mailing list