[coreboot-gerrit] Patch set updated for coreboot: vendorcode/amd: Remove dead code
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Aug 8 12:26:49 CEST 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16112
-gerrit
commit b5a81e47c18d10af1eae500098161284c6afce01
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Mon Aug 8 11:43:43 2016 +0200
vendorcode/amd: Remove dead code
Change-Id: I6b21822d60d379cb8cd21b69c714a437bb7977ce
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Found-by: Coverity Scan #1254643 and others
---
src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c | 42 -------------------------
src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c | 42 -------------------------
2 files changed, 84 deletions(-)
diff --git a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
index 7a6851d..c207d67 100644
--- a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
@@ -438,13 +438,7 @@ WaitForEcLDN9MailboxCmdAck (
IN AMD_CONFIG_PARAMS *StdHeader
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(StdHeader);
}
/**
@@ -459,13 +453,7 @@ ImcSleep (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -480,13 +468,7 @@ SoftwareDisableImc (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -501,13 +483,7 @@ ImcEnableSurebootTimer (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -522,13 +498,7 @@ ImcDisableSurebootTimer (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -543,13 +513,7 @@ ImcWakeup (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -564,13 +528,7 @@ ImcIdle (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
// TODO This has to be removed
diff --git a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
index b58107c..82744dd 100644
--- a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
@@ -436,13 +436,7 @@ WaitForEcLDN9MailboxCmdAck (
IN AMD_CONFIG_PARAMS *StdHeader
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(StdHeader);
}
/**
@@ -457,13 +451,7 @@ ImcSleep (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -478,13 +466,7 @@ SoftwareDisableImc (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -499,13 +481,7 @@ ImcEnableSurebootTimer (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -520,13 +496,7 @@ ImcDisableSurebootTimer (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -541,13 +511,7 @@ ImcWakeup (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
/**
@@ -562,13 +526,7 @@ ImcIdle (
IN VOID *FchDataPtr
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
((FCH_DATA_BLOCK*)FchDataPtr)->StdHeader->Func = 0;
- return;
- if (!module) return;
- Dispatcher = module->ModuleDispatcher;
- Dispatcher(FchDataPtr);
}
// TODO This has to be removed
More information about the coreboot-gerrit
mailing list