[coreboot-gerrit] Patch set updated for coreboot: vendorcode/amd/pi/Lib: Fix reporting fatal error

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Aug 8 12:26:55 CEST 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16058

-gerrit

commit 9d54c2fc423e48ce727c4112abe8ebdca4e2b452
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Wed Aug 3 23:10:36 2016 +0200

    vendorcode/amd/pi/Lib: Fix reporting fatal error
    
    Instead of writing the first word of 6 "post code structs" where only
    one exists (leading to 0xDEAD and 5 garbage words), write the correct
    set.
    
    Change-Id: Ifdfa53a970dda33dc9dc8c05788875077c001ecf
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1361054, #1361055, #1361056
---
 src/vendorcode/amd/pi/Lib/amdlib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vendorcode/amd/pi/Lib/amdlib.c b/src/vendorcode/amd/pi/Lib/amdlib.c
index 5e85f6b..4c8a56d 100644
--- a/src/vendorcode/amd/pi/Lib/amdlib.c
+++ b/src/vendorcode/amd/pi/Lib/amdlib.c
@@ -1408,7 +1408,7 @@ IdsErrorStop (
 
 	while(1) {
 		offset %= sizeof(struct POST) / 2;
-		WriteIo32(80, *((UINT32*)(&post+offset)));
+		WriteIo16(80, *((UINT16 *)&post)+offset);
 		++offset;
 		for (j=0; j<250; ++j) {
 			ReadIo8(80);



More information about the coreboot-gerrit mailing list