[coreboot-gerrit] Patch merged into coreboot/master: libpayload: lzma: Allocate scratchpad on the heap

gerrit at coreboot.org gerrit at coreboot.org
Mon Aug 8 19:02:13 CEST 2016


the following patch was just integrated into master:
commit e25d3ff9bd63cb7123461b266b42af664e81025d
Author: Julius Werner <jwerner at chromium.org>
Date:   Fri Aug 5 20:43:47 2016 -0700

    libpayload: lzma: Allocate scratchpad on the heap
    
    Allocating a 15980-byte scratchpad on the stack when your default stack
    size is set to 16KB is really not a great idea. We're regularly
    overflowing into the end of our heap when using LZMA in libpayload, and
    just happen not to notice it because the heap rarely gets filled up all
    the way. Of course, since we always *have* a heap in libpayload, the
    much saner solution is to just use it directly to allocate the
    scratchpad rather than accidentally grow backwards into it anyway.
    
    Change-Id: Ibe4f02057a32bd156a126302178fa6fcab637d2c
    Signed-off-by: Julius Werner <jwerner at chromium.org>
    Reviewed-on: https://review.coreboot.org/16089
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See https://review.coreboot.org/16089 for details.

-gerrit



More information about the coreboot-gerrit mailing list