[coreboot-gerrit] New patch to review for coreboot: Revert "lenovo/x60: Fetch 16 bits when trying to parse bit 13"

Antonello Dettori (dev@dettori.io) gerrit at coreboot.org
Tue Aug 9 22:41:03 CEST 2016


Antonello Dettori (dev at dettori.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16132

-gerrit

commit 0525f148a0ab2a617ecf7240c9866db5fc99f6fa
Author: Antonello Dettori <dev at dettori.io>
Date:   Tue Aug 9 22:41:01 2016 +0200

    Revert "lenovo/x60: Fetch 16 bits when trying to parse bit 13"
    
    It broke the dock support altogether.
    
    This reverts commit b9eee8e468a78789dce8d5af12274fc0dc2d5007.
    
    Change-Id: Ib8a721b33bd2f8ce3948a3da0b231cc2e45e3cda
---
 src/mainboard/lenovo/x60/dock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/lenovo/x60/dock.c b/src/mainboard/lenovo/x60/dock.c
index c2bed9a..ca82d38 100644
--- a/src/mainboard/lenovo/x60/dock.c
+++ b/src/mainboard/lenovo/x60/dock.c
@@ -255,7 +255,7 @@ void dock_disconnect(void)
 
 int dock_present(void)
 {
-	return !((inw(DEFAULT_GPIOBASE + 0x0c) >> 13) & 1);
+	return !((inb(DEFAULT_GPIOBASE + 0x0c) >> 13) & 1);
 }
 
 int dock_ultrabay_device_present(void)



More information about the coreboot-gerrit mailing list