[coreboot-gerrit] Patch set updated for coreboot: lenovo/x60: add GPIOs initialisation before dock check
Antonello Dettori (dev@dettori.io)
gerrit at coreboot.org
Wed Aug 10 15:21:19 CEST 2016
Antonello Dettori (dev at dettori.io) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16139
-gerrit
commit dc95b8f4004af156c9613babee8a6951626d6edc
Author: Antonello Dettori <dev at dettori.io>
Date: Wed Aug 10 14:32:07 2016 +0200
lenovo/x60: add GPIOs initialisation before dock check
Add GPIOs initialisation before dock check.
Needed in order to properly detect the presence or absence of the lenovo
dock.
Previously the check always reported the dock as connected and currently
it always reports it as disconnected since the GPIOs are not properly
initialised during the check.
Tested and confirmed working.
Change-Id: I7fbf8c2262a1eb5dee9cbe5e23bf44f7f8181009
Signed-off-by: Antonello Dettori <dev at dettori.io>
---
src/mainboard/lenovo/x60/romstage.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/mainboard/lenovo/x60/romstage.c b/src/mainboard/lenovo/x60/romstage.c
index 1f249a6..46904b2 100644
--- a/src/mainboard/lenovo/x60/romstage.c
+++ b/src/mainboard/lenovo/x60/romstage.c
@@ -224,6 +224,10 @@ void mainboard_romstage_entry(unsigned long bist)
udelay(200 * 1000);
pci_write_config16(PCI_DEV(0, 0x1e, 0), BCTRL, 0);
+ /* Enable GPIOs */
+ pci_write_config32(PCI_DEV(0, 0x1f, 0), GPIOBASE, DEFAULT_GPIOBASE | 1);
+ pci_write_config8(PCI_DEV(0, 0x1f, 0), 0x4c, 0x10); /* 0x4c == GC */
+
ich7_enable_lpc();
dlpc_init();
More information about the coreboot-gerrit
mailing list