[coreboot-gerrit] Patch set updated for coreboot: soc/qualcomm/ipq40xx: Reduce the delay in I2C.
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Thu Aug 11 20:22:31 CEST 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16126
-gerrit
commit 56f09974b840753bf40753d04c0baa7bfc4be434
Author: Kan Yan <kyan at google.com>
Date: Thu Jun 30 13:46:56 2016 -0700
soc/qualcomm/ipq40xx: Reduce the delay in I2C.
3ms delay was found in testing to be sufficient for
qup_i2c_write_fifo_flush(), but 1 additional ms was added to give
additional headroom.
Change the Delay from 10ms to 4ms.
BUG=b:28942403
TEST=Boot up Gale board and the TPM functions normally.
BRANCH=None
Change-Id: I6821e2a101cc44e11d74eb6a6215aa9b848ae8c6
Signed-off-by: Martin Roth <martinroth at chromium.org>
Original-Commit-Id: d93520fab15c5695ea18db21d0f3b24a108f204d
Original-Change-Id: I202f5b8a1ef62bb039c56ba5a25b48b205cf4a67
Original-Signed-off-by: Kan Yan <kyan at google.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/357961
Original-Reviewed-by: Suresh Rajashekara <sureshraj at chromium.org>
Original-Reviewed-by: SARAVANAKUMAR SUDALAI <ssudalai at qti.qualcomm.com>
---
src/soc/qualcomm/ipq40xx/qup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/qualcomm/ipq40xx/qup.c b/src/soc/qualcomm/ipq40xx/qup.c
index d2c1f28..9276e14 100644
--- a/src/soc/qualcomm/ipq40xx/qup.c
+++ b/src/soc/qualcomm/ipq40xx/qup.c
@@ -175,7 +175,7 @@ static inline qup_return_t qup_i2c_write_fifo_flush(blsp_qup_id_t id)
qup_write32(QUP_ADDR(id, QUP_OPERATIONAL), OUTPUT_SERVICE_FLAG);
- mdelay(10); /* TPM seems to need this */
+ mdelay(4); /* TPM seems to need this */
ret = qup_fifo_wait_while(id, OUTPUT_FIFO_NOT_EMPTY);
if (ret)
More information about the coreboot-gerrit
mailing list