[coreboot-gerrit] Patch set updated for coreboot: drivers/intel/fsp2_0: Fix FSP reset path

Lee Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Fri Aug 12 03:27:17 CEST 2016


Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16162

-gerrit

commit 8a3632dbb26f145ecbb829e07143378978991e95
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Thu Aug 11 17:40:01 2016 -0700

    drivers/intel/fsp2_0: Fix FSP reset path
    
    Don't verify HOB list pointer or HOBs when FSP returns a reset request.
    
    BRANCH=none
    BUG=chrome-os-partner:56159
    TEST=Build and run on Galileo Gen2.
    
    Change-Id: I6382f5ff92092623955806ebff340608c4ee156a
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
 src/drivers/intel/fsp2_0/debug.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/drivers/intel/fsp2_0/debug.c b/src/drivers/intel/fsp2_0/debug.c
index 6d88f02..a003569 100644
--- a/src/drivers/intel/fsp2_0/debug.c
+++ b/src/drivers/intel/fsp2_0/debug.c
@@ -49,6 +49,9 @@ void fsp_debug_after_memory_init(enum fsp_status status)
 	if (IS_ENABLED(CONFIG_DISPLAY_FSP_CALLS_AND_STATUS))
 		printk(BIOS_SPEW, "FspMemoryInit returned 0x%08x\n", status);
 
+	if (status != FSP_SUCCESS)
+		return;
+
 	/* Verify that the HOB list pointer was set */
 	if (fsp_get_hob_list() == NULL)
 		die("ERROR - HOB list pointer was not returned!\n");



More information about the coreboot-gerrit mailing list