[coreboot-gerrit] Patch set updated for coreboot: commonlib/region: allow empty mmap()/munmap() in region_device_ops

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Fri Aug 12 23:28:39 CEST 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16190

-gerrit

commit d394d404125881f3924d8068697007a3957424f9
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Aug 10 11:39:00 2016 -0500

    commonlib/region: allow empty mmap()/munmap() in region_device_ops
    
    Instead of assuming all region_devices have an mmap() and munmap()
    implementation fail those calls when one isn't provided.
    
    BUG=chrome-os-partner:56151
    
    Change-Id: I9b03e084aa604d52d6b5bab47c0bf99d9fbcd422
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/commonlib/region.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/commonlib/region.c b/src/commonlib/region.c
index 838107f..ac0faf1 100644
--- a/src/commonlib/region.c
+++ b/src/commonlib/region.c
@@ -74,6 +74,9 @@ void *rdev_mmap(const struct region_device *rd, size_t offset, size_t size)
 
 	rdev = rdev_root(rd);
 
+	if (rdev->ops->mmap == NULL)
+		return NULL;
+
 	return rdev->ops->mmap(rdev, req.offset, req.size);
 }
 
@@ -83,6 +86,9 @@ int rdev_munmap(const struct region_device *rd, void *mapping)
 
 	rdev = rdev_root(rd);
 
+	if (rdev->ops->munmap == NULL)
+		return -1;
+
 	return rdev->ops->munmap(rdev, mapping);
 }
 



More information about the coreboot-gerrit mailing list