[coreboot-gerrit] Patch set updated for coreboot: src/southbridge: Unnecessary whitespace before "\n" and "\t" removed

HAOUAS Elyes (ehaouas@noos.fr) gerrit at coreboot.org
Sun Aug 21 15:57:52 CEST 2016


HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16281

-gerrit

commit 02c90a87e26f482c68acc7e79874d3a3011a6471
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Sun Aug 21 12:06:54 2016 +0200

    src/southbridge: Unnecessary whitespace before "\n" and "\t" removed
    
    Change-Id: I42cc5b8736e73728c5deec6349e8d2a814e19e83
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/southbridge/amd/amd8132/bridge.c     |  2 +-
 src/southbridge/amd/rs780/gfx.c          | 80 ++++++++++++++++----------------
 src/southbridge/intel/fsp_rangeley/lpc.c |  2 +-
 src/southbridge/nvidia/ck804/ide.c       |  2 +-
 src/southbridge/nvidia/ck804/lpc.c       |  2 +-
 src/southbridge/nvidia/ck804/sata.c      |  2 +-
 src/southbridge/nvidia/mcp55/ide.c       |  2 +-
 src/southbridge/nvidia/mcp55/sata.c      |  6 +--
 src/southbridge/sis/sis966/aza.c         |  2 +-
 src/southbridge/sis/sis966/ide.c         |  2 +-
 src/southbridge/sis/sis966/nic.c         |  6 +--
 11 files changed, 54 insertions(+), 54 deletions(-)

diff --git a/src/southbridge/amd/amd8132/bridge.c b/src/southbridge/amd/amd8132/bridge.c
index ee45c65..b1f9d14 100644
--- a/src/southbridge/amd/amd8132/bridge.c
+++ b/src/southbridge/amd/amd8132/bridge.c
@@ -151,7 +151,7 @@ static void amd8132_scan_bus(struct bus *bus,
 	info.sstatus = pci_read_config16(bus->dev, pos + PCI_X_SEC_STATUS);
 
 	/* Print the PCI-X bus speed */
-	printk(BIOS_DEBUG, "PCI: %02x: %s sstatus=%04x rev=%02x \n", bus->secondary, pcix_speed(info.sstatus), info.sstatus, info.rev);
+	printk(BIOS_DEBUG, "PCI: %02x: %s sstatus=%04x rev=%02x\n", bus->secondary, pcix_speed(info.sstatus), info.sstatus, info.rev);
 
 
 	/* Examine the bus and find out how loaded it is */
diff --git a/src/southbridge/amd/rs780/gfx.c b/src/southbridge/amd/rs780/gfx.c
index 8499a4d..6d27d56 100644
--- a/src/southbridge/amd/rs780/gfx.c
+++ b/src/southbridge/amd/rs780/gfx.c
@@ -197,7 +197,7 @@ static CIM_STATUS GetCreativeMMIO(MMIORANGE *pMMIO)
 		{
 			tempdev = dev_find_slot(Bus, Dev << 3);
 			Value = pci_read_config32(tempdev, 0);
-			printk(BIOS_DEBUG, "Dev ID %x \n", Value);
+			printk(BIOS_DEBUG, "Dev ID %x\n", Value);
 			if((Value & 0xffff) == 0x1102)
 			{//Creative
 				//Found Creative SB
@@ -228,7 +228,7 @@ static CIM_STATUS GetCreativeMMIO(MMIORANGE *pMMIO)
 						}
 					}
 				}
-				printk(BIOS_DEBUG, " MMIOStart %x MMIOLimit %x \n", MMIOStart, MMIOLimit);
+				printk(BIOS_DEBUG, " MMIOStart %x MMIOLimit %x\n", MMIOStart, MMIOLimit);
 				if (MMIOStart < MMIOLimit)
 				{
 					Status = SetMMIO(MMIOStart>>8, MMIOLimit>>8, 0x80, pMMIO);
@@ -570,44 +570,44 @@ static void internal_gfx_pci_dev_init(struct device *dev)
 	poweron_ddi_lanes(nb_dev);
 
 	printk(BIOS_DEBUG,"vgainfo:\n"
-			"  ulBootUpEngineClock:%lu \n"
-			"  ulBootUpUMAClock:%lu \n"
-			"  ulBootUpSidePortClock:%lu \n"
-			"  ulMinSidePortClock:%lu \n"
-			"  ulSystemConfig:%lu \n"
-			"  ulBootUpReqDisplayVector:%lu \n"
-			"  ulOtherDisplayMisc:%lu \n"
-			"  ulDDISlot1Config:%lu \n"
-			"  ulDDISlot2Config:%lu \n"
-
-			"  ucMemoryType:%u \n"
-			"  ucUMAChannelNumber:%u \n"
-			"  ucDockingPinBit:%u \n"
-			"  ucDockingPinPolarity:%u \n"
-
-			"  ulDockingPinCFGInfo:%lu \n"
-			"  ulCPUCapInfo: %lu \n"
-
-			"  usNumberOfCyclesInPeriod:%hu \n"
-			"  usMaxNBVoltage:%hu \n"
-			"  usMinNBVoltage:%hu \n"
-			"  usBootUpNBVoltage:%hu \n"
-
-			"  ulHTLinkFreq:%lu \n"
-
-			"  usMinHTLinkWidth:%hu \n"
-			"  usMaxHTLinkWidth:%hu \n"
-			"  usUMASyncStartDelay:%hu \n"
-			"  usUMADataReturnTime:%hu \n"
-			"  usLinkStatusZeroTime:%hu \n"
-
-			"  ulHighVoltageHTLinkFreq:%lu \n"
-			"  ulLowVoltageHTLinkFreq:%lu \n"
-
-			"  usMaxUpStreamHTLinkWidth:%hu \n"
-			"  usMaxDownStreamHTLinkWidth:%hu \n"
-			"  usMinUpStreamHTLinkWidth:%hu \n"
-			"  usMinDownStreamHTLinkWidth:%hu \n",
+			"  ulBootUpEngineClock:%lu\n"
+			"  ulBootUpUMAClock:%lu\n"
+			"  ulBootUpSidePortClock:%lu\n"
+			"  ulMinSidePortClock:%lu\n"
+			"  ulSystemConfig:%lu\n"
+			"  ulBootUpReqDisplayVector:%lu\n"
+			"  ulOtherDisplayMisc:%lu\n"
+			"  ulDDISlot1Config:%lu\n"
+			"  ulDDISlot2Config:%lu\n"
+
+			"  ucMemoryType:%u\n"
+			"  ucUMAChannelNumber:%u\n"
+			"  ucDockingPinBit:%u\n"
+			"  ucDockingPinPolarity:%u\n"
+
+			"  ulDockingPinCFGInfo:%lu\n"
+			"  ulCPUCapInfo: %lu\n"
+
+			"  usNumberOfCyclesInPeriod:%hu\n"
+			"  usMaxNBVoltage:%hu\n"
+			"  usMinNBVoltage:%hu\n"
+			"  usBootUpNBVoltage:%hu\n"
+
+			"  ulHTLinkFreq:%lu\n"
+
+			"  usMinHTLinkWidth:%hu\n"
+			"  usMaxHTLinkWidth:%hu\n"
+			"  usUMASyncStartDelay:%hu\n"
+			"  usUMADataReturnTime:%hu\n"
+			"  usLinkStatusZeroTime:%hu\n"
+
+			"  ulHighVoltageHTLinkFreq:%lu\n"
+			"  ulLowVoltageHTLinkFreq:%lu\n"
+
+			"  usMaxUpStreamHTLinkWidth:%hu\n"
+			"  usMaxDownStreamHTLinkWidth:%hu\n"
+			"  usMinUpStreamHTLinkWidth:%hu\n"
+			"  usMinDownStreamHTLinkWidth:%hu\n",
 
 			(unsigned long)vgainfo.ulBootUpEngineClock,
 			(unsigned long)vgainfo.ulBootUpUMAClock,
diff --git a/src/southbridge/intel/fsp_rangeley/lpc.c b/src/southbridge/intel/fsp_rangeley/lpc.c
index 3a144ea..11aa60d 100644
--- a/src/southbridge/intel/fsp_rangeley/lpc.c
+++ b/src/southbridge/intel/fsp_rangeley/lpc.c
@@ -210,7 +210,7 @@ static void soc_pirq_init(device_t dev)
 
 	/* Set up the PIRQ PIC routing based on static config. */
 	printk(BIOS_SPEW, "Start writing IRQ assignments\n"
-			"PIRQ\tA \tB \tC \tD \tE \tF \tG \tH\n"
+			"PIRQ\tA\tB\tC\tD\tE\tF\tG\tH\n"
 			"IRQ ");
 	for (i = 0; i < NUM_PIRQS; i++) {
 		write8(pr_base + i*sizeof(ir->pic[i]), ir->pic[i]);
diff --git a/src/southbridge/nvidia/ck804/ide.c b/src/southbridge/nvidia/ck804/ide.c
index 8914f2a..a4b5475 100644
--- a/src/southbridge/nvidia/ck804/ide.c
+++ b/src/southbridge/nvidia/ck804/ide.c
@@ -36,7 +36,7 @@ static void ide_init(struct device *dev)
 	if (conf->ide1_enable) {
 		/* Enable secondary IDE interface. */
 		word |= (1 << 0);
-		printk(BIOS_DEBUG, "IDE1 \t");
+		printk(BIOS_DEBUG, "IDE1\t");
 	}
 	if (conf->ide0_enable) {
 		/* Enable primary IDE interface. */
diff --git a/src/southbridge/nvidia/ck804/lpc.c b/src/southbridge/nvidia/ck804/lpc.c
index 34e24f1..d15ef8e 100644
--- a/src/southbridge/nvidia/ck804/lpc.c
+++ b/src/southbridge/nvidia/ck804/lpc.c
@@ -111,7 +111,7 @@ static void lpc_init(device_t dev)
 	lpc_common_init(dev);
 
 	pm_base = pci_read_config32(dev, 0x60) & 0xff00;
-	printk(BIOS_INFO, "%s: pm_base = %x \n", __func__, pm_base);
+	printk(BIOS_INFO, "%s: pm_base = %x\n", __func__, pm_base);
 
 	/* Power after power fail */
 	on = CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL;
diff --git a/src/southbridge/nvidia/ck804/sata.c b/src/southbridge/nvidia/ck804/sata.c
index eeebf89..b67cf28 100644
--- a/src/southbridge/nvidia/ck804/sata.c
+++ b/src/southbridge/nvidia/ck804/sata.c
@@ -102,7 +102,7 @@ static void sata_init(struct device *dev)
 	if (conf->sata1_enable) {
 		/* Enable secondary SATA interface. */
 		dword |= (1 << 0);
-		printk(BIOS_DEBUG, "SATA S \t");
+		printk(BIOS_DEBUG, "SATA S\t");
 	}
 	if (conf->sata0_enable) {
 		/* Enable primary SATA interface. */
diff --git a/src/southbridge/nvidia/mcp55/ide.c b/src/southbridge/nvidia/mcp55/ide.c
index 4e61874..797b9d8 100644
--- a/src/southbridge/nvidia/mcp55/ide.c
+++ b/src/southbridge/nvidia/mcp55/ide.c
@@ -38,7 +38,7 @@ static void ide_init(struct device *dev)
 	if (conf->ide1_enable) {
 		/* Enable secondary IDE interface. */
 		word |= (1 << 0);
-		printk(BIOS_DEBUG, "IDE1 \t");
+		printk(BIOS_DEBUG, "IDE1\t");
 	}
 	if (conf->ide0_enable) {
 		/* Enable primary IDE interface. */
diff --git a/src/southbridge/nvidia/mcp55/sata.c b/src/southbridge/nvidia/mcp55/sata.c
index 78cd27a..fa761d2 100644
--- a/src/southbridge/nvidia/mcp55/sata.c
+++ b/src/southbridge/nvidia/mcp55/sata.c
@@ -39,16 +39,16 @@ static void sata_init(struct device *dev)
 		if (conf->sata1_enable) {
 			/* Enable secondary SATA interface */
 			dword |= (1<<0);
-			printk(BIOS_DEBUG, "SATA S \t");
+			printk(BIOS_DEBUG, "SATA S\t");
 		}
 		if (conf->sata0_enable) {
 			/* Enable primary SATA interface */
 			dword |= (1<<1);
-			printk(BIOS_DEBUG, "SATA P \n");
+			printk(BIOS_DEBUG, "SATA P\n");
 		}
 	} else {
 		dword |= (1<<1) | (1<<0);
-		printk(BIOS_DEBUG, "SATA P and S \n");
+		printk(BIOS_DEBUG, "SATA P and S\n");
 	}
 
 
diff --git a/src/southbridge/sis/sis966/aza.c b/src/southbridge/sis/sis966/aza.c
index a7c3319..e442ea2 100644
--- a/src/southbridge/sis/sis966/aza.c
+++ b/src/southbridge/sis/sis966/aza.c
@@ -100,7 +100,7 @@ static int codec_detect(u8 *base)
 
       do{
 	  	dword = read32(base + 0x08)&0x1;
-		if(idx++>1000) { printk(BIOS_DEBUG, "controller reset fail !!! \n"); break;}
+		if(idx++>1000) { printk(BIOS_DEBUG, "controller reset fail !!!\n"); break;}
 	   } while (dword !=1);
 
        dword=send_verb(base,0x000F0000); // get codec VendorId and DeviceId
diff --git a/src/southbridge/sis/sis966/ide.c b/src/southbridge/sis/sis966/ide.c
index f3fa079..dcd11ac 100644
--- a/src/southbridge/sis/sis966/ide.c
+++ b/src/southbridge/sis/sis966/ide.c
@@ -120,7 +120,7 @@ printk(BIOS_DEBUG, "IDE_INIT:---------->\n");
 	if (conf->ide1_enable) {
 		/* Enable secondary ide interface */
 		word |= (1<<0);
-		printk(BIOS_DEBUG, "IDE1 \t");
+		printk(BIOS_DEBUG, "IDE1\t");
 	}
 	if (conf->ide0_enable) {
 		/* Enable primary ide interface */
diff --git a/src/southbridge/sis/sis966/nic.c b/src/southbridge/sis/sis966/nic.c
index cd376ab..e48454d 100644
--- a/src/southbridge/sis/sis966/nic.c
+++ b/src/southbridge/sis/sis966/nic.c
@@ -221,7 +221,7 @@ static int phy_detect(u8 *base,u16 *PhyAddr) //BOOL PHY_Detect()
 
 	if(!bFoundPhy)
 	{
-	    printk(BIOS_DEBUG, "PHY not found !!!! \n");
+	    printk(BIOS_DEBUG, "PHY not found !!!!\n");
 	}
 
        *PhyAddr=PhyAddress;
@@ -283,7 +283,7 @@ static void nic_init(struct device *dev)
 
           //	if that is valid we will use that
 
-			printk(BIOS_DEBUG, "EEPROM contents %lx \n",ReadEEprom( dev,  base,  0LL));
+			printk(BIOS_DEBUG, "EEPROM contents %lx\n",ReadEEprom( dev,  base,  0LL));
 			for(i=0;i<3;i++) {
 				//status = smbus_read_byte(dev_eeprom, i);
 				ulValue=ReadEEprom( dev,  base,  i+3L);
@@ -294,7 +294,7 @@ static void nic_init(struct device *dev)
 			}
         }else{
                  // read MAC address from firmware
-		 printk(BIOS_DEBUG, "EEPROM invalid!!\nReg 0x38h=%.8lx \n",ulValue);
+		 printk(BIOS_DEBUG, "EEPROM invalid!!\nReg 0x38h=%.8lx\n",ulValue);
 		 MacAddr[0]=read16((u16 *)0xffffffc0); // mac address store at here
 		 MacAddr[1]=read16((u16 *)0xffffffc2);
 		 MacAddr[2]=read16((u16 *)0xffffffc4);



More information about the coreboot-gerrit mailing list