[coreboot-gerrit] Patch merged into coreboot/master: vboot: consolidate google_chromeec_early_init() calls

gerrit at coreboot.org gerrit at coreboot.org
Thu Aug 25 22:50:20 CEST 2016


the following patch was just integrated into master:
commit f7ce40baf6a26e70ca18026f26977cd7f6f2cefa
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Aug 24 14:58:12 2016 -0500

    vboot: consolidate google_chromeec_early_init() calls
    
    On x86 platforms, google_chromeec_early_init() is used to put the EC
    into RO mode when there's a recovery request. This is to avoid training
    memory multiple times when the recovery request is through an EC host
    event while the EC is running RW code. Under that condition the EC will
    be reset (along with the rest of the system) when the kernel verification
    happens. This leads to an execessively long recovery path because of the
    double reboot performing full memory training each time.
    
    By putting this logic into the verstage program this reduces the
    bootblock size on the skylake boards. Additionally, this provides the
    the correct logic for all future boards since it's not tied to FSP
    nor the mainboard itself. Lastly, this double memory training protection
    works only for platforms which verify starting from bootblock. The
    platforms which don't start verifying until after romstage need to
    have their own calls (such as haswell and baytrail).
    
    Change-Id: Ia8385dfc136b09fb20bd3519f3cc621e540b11a5
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/16318
    Tested-by: build bot (Jenkins)
    Reviewed-by: Furquan Shaikh <furquan at google.com>


See https://review.coreboot.org/16318 for details.

-gerrit



More information about the coreboot-gerrit mailing list