[coreboot-gerrit] Patch set updated for coreboot: Update .checkpatch.conf

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Tue Aug 30 17:40:08 CEST 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16010

-gerrit

commit c9aa1efe8ca1f389ed307f66adad889773867304
Author: Stefan Reinauer <reinauer at chromium.org>
Date:   Mon Aug 1 12:21:30 2016 -0700

    Update .checkpatch.conf
    
    - Don't require a description of every config statement in the
    Kconfig changes
    - Don't complain about externs in .c files
    - Don't complain about the use of the volatile keyword.  The kernel
    may not want it, but we definitely need it.
    - Disable checks that seem to be broken.
    
    Change-Id: Ic419b81cd36852a91e887e610d4a04984ab5fbd7
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 .checkpatch.conf | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/.checkpatch.conf b/.checkpatch.conf
index f7b9b32..f194ced 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -1,9 +1,6 @@
 # Not Linux, so don't expect a Linux tree.
 --no-tree
 
-# Require every Kconfig symbol to have at least two lines in their description.
---min-conf-desc-length=2
-
 # Ignore aspects we don't follow here.
 --ignore C99_COMMENTS
 --ignore GLOBAL_INITIALISERS
@@ -15,3 +12,15 @@
 --ignore PREFER_PRINTF
 --ignore SPLIT_STRING
 --ignore BLOCK_COMMENT_STYLE
+--ignore AVOID_EXTERNS
+--ignore VOLATILE
+--ignore CONFIG_DESCRIPTION
+
+# FILE_PATH_CHANGES seems to not be working correctly. It will
+# choke on added / deleted files even if the MAINTAINERS file
+# is touched.
+--ignore FILE_PATH_CHANGES
+
+# This one has a linux path hard coded, so it would choke on
+# some commits unnecessarily.
+--ignore EXECUTE_PERMISSIONS



More information about the coreboot-gerrit mailing list