[coreboot-gerrit] Patch set updated for coreboot: lenovo/t400: configure GPIO's correctly for hybrid graphics

Arthur Heymans (arthur@aheymans.xyz) gerrit at coreboot.org
Wed Aug 31 14:38:37 CEST 2016


Arthur Heymans (arthur at aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16380

-gerrit

commit 15f4351289a62938ecef3dc0d5c3d07a165aeeba
Author: Arthur Heymans <arthur at aheymans.xyz>
Date:   Wed Aug 31 13:03:46 2016 +0200

    lenovo/t400: configure GPIO's correctly for hybrid graphics
    
    GPIO17 is DGFX_PWRGD according to T400 schematics "MALIBU-3 EXT". This
    GPIO needs to be an output, which this patch fixes.
    
    This patch also sets all GPIO's that are needed to for hybrid grahpics to
    LOW to enable IGD, which is the default in cmos.default.
    
    Change-Id: I1efff3a869a460bd77e490aa55e24bb1a9e307cc
    Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
 src/mainboard/lenovo/t400/gpio.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/lenovo/t400/gpio.h b/src/mainboard/lenovo/t400/gpio.h
index 0484bf2..8a61ac0 100644
--- a/src/mainboard/lenovo/t400/gpio.h
+++ b/src/mainboard/lenovo/t400/gpio.h
@@ -56,7 +56,7 @@ const struct pch_gpio_set1 pch_gpio_set1_direction = {
 	.gpio14 = GPIO_DIR_INPUT,
 	.gpio15 = GPIO_DIR_OUTPUT,
 	.gpio16 = GPIO_DIR_OUTPUT,
-	.gpio17 = GPIO_DIR_INPUT,
+	.gpio17 = GPIO_DIR_OUTPUT,
 	.gpio18 = GPIO_DIR_INPUT,
 	.gpio19 = GPIO_DIR_OUTPUT,
 	.gpio20 = GPIO_DIR_OUTPUT,
@@ -91,12 +91,12 @@ const struct pch_gpio_set1 pch_gpio_set1_level = {
 	.gpio14 = GPIO_LEVEL_HIGH,
 	.gpio15 = GPIO_LEVEL_HIGH,
 	.gpio16 = GPIO_LEVEL_LOW,
-	.gpio17 = GPIO_LEVEL_HIGH,
+	.gpio17 = GPIO_LEVEL_LOW,
 	.gpio18 = GPIO_LEVEL_LOW,
-	.gpio19 = GPIO_LEVEL_HIGH,
+	.gpio19 = GPIO_LEVEL_LOW,
 	.gpio20 = GPIO_LEVEL_HIGH,
 	.gpio21 = GPIO_LEVEL_HIGH,
-	.gpio22 = GPIO_LEVEL_HIGH,
+	.gpio22 = GPIO_LEVEL_LOW,
 	.gpio23 = GPIO_LEVEL_HIGH,
 	.gpio24 = GPIO_LEVEL_HIGH,
 	.gpio25 = GPIO_LEVEL_HIGH,
@@ -266,7 +266,7 @@ const struct pch_gpio_set2 pch_gpio_set2_level = {
 	.gpio46 = GPIO_LEVEL_HIGH,
 	.gpio47 = GPIO_LEVEL_HIGH,
 	.gpio48 = GPIO_LEVEL_HIGH,
-	.gpio49 = GPIO_LEVEL_HIGH,
+	.gpio49 = GPIO_LEVEL_LOW,
 	.gpio50 = GPIO_LEVEL_HIGH,
 	.gpio51 = GPIO_LEVEL_HIGH,
 	.gpio52 = GPIO_LEVEL_HIGH,



More information about the coreboot-gerrit mailing list