[coreboot-gerrit] New patch to review for coreboot: google/beltino: fix LED for Tricky variant
Matt DeVillier (matt.devillier@gmail.com)
gerrit at coreboot.org
Mon Dec 5 00:31:18 CET 2016
Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17719
-gerrit
commit cca16ab430cbe671ffe9f6e3e5027305ea4c6cc5
Author: Matt DeVillier <matt.devillier at gmail.com>
Date: Fri Dec 2 23:27:32 2016 -0600
google/beltino: fix LED for Tricky variant
Polarity value for Tricky's power LED was incorrect for the 'on' state;
fix using correct value from Chromium source
TEST: power on Tricky, observe LED lit / solid
Change-Id: I8bc7c4ae3f83d3f37b76fd5c90a4faed7057ebee
Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
src/mainboard/google/beltino/variants/tricky/led.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mainboard/google/beltino/variants/tricky/led.c b/src/mainboard/google/beltino/variants/tricky/led.c
index 72498a3..9bf561d 100644
--- a/src/mainboard/google/beltino/variants/tricky/led.c
+++ b/src/mainboard/google/beltino/variants/tricky/led.c
@@ -25,7 +25,7 @@ void set_power_led(int state)
it8772f_gpio_led(IT8772F_GPIO_DEV,
2 /* set */,
0xF7 /* select */,
- state /* polarity: state dependent */,
+ 0x04 * state /* polarity: state dependent */,
0x00 /* 0=pulldown */,
0x04 /* output */,
0x04 /* 1=Simple IO function */,
More information about the coreboot-gerrit
mailing list