[coreboot-gerrit] Patch set updated for coreboot: PCI ops: Remove pci_mmio_xx() in ramstage

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Tue Dec 6 09:45:26 CET 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17691

-gerrit

commit 7e948de6a0d662f08487eeeeac036c79ebf9ca98
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Dec 2 08:06:55 2016 +0200

    PCI ops: Remove pci_mmio_xx() in ramstage
    
    MMCONF operations are already the default so these
    would never be used.
    
    Change-Id: I671f3d2847742e400bc4ecfccc088e3b79d43070
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/device/pci_ops.c         | 45 --------------------------------------------
 src/include/device/pci_ops.h |  8 --------
 2 files changed, 53 deletions(-)

diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c
index ab72405..2f896d2 100644
--- a/src/device/pci_ops.c
+++ b/src/device/pci_ops.c
@@ -118,48 +118,3 @@ void pci_write_config32(struct device *dev, unsigned int where, u32 val)
 	pci_bus_ops(pbus, dev)->write32(pbus, dev->bus->secondary,
 				   dev->path.pci.devfn, where, val);
 }
-
-#if CONFIG_MMCONF_SUPPORT
-u8 pci_mmio_read_config8(struct device *dev, unsigned int where)
-{
-	struct bus *pbus = get_pbus(dev);
-	return pci_ops_mmconf.read8(pbus, dev->bus->secondary,
-				    dev->path.pci.devfn, where);
-}
-
-u16 pci_mmio_read_config16(struct device *dev, unsigned int where)
-{
-	struct bus *pbus = get_pbus(dev);
-	return pci_ops_mmconf.read16(pbus, dev->bus->secondary,
-				     dev->path.pci.devfn, where);
-}
-
-u32 pci_mmio_read_config32(struct device *dev, unsigned int where)
-{
-	struct bus *pbus = get_pbus(dev);
-	return pci_ops_mmconf.read32(pbus, dev->bus->secondary,
-				     dev->path.pci.devfn, where);
-}
-
-void pci_mmio_write_config8(struct device *dev, unsigned int where, u8 val)
-{
-	struct bus *pbus = get_pbus(dev);
-	pci_ops_mmconf.write8(pbus, dev->bus->secondary, dev->path.pci.devfn,
-			      where, val);
-}
-
-void pci_mmio_write_config16(struct device *dev, unsigned int where, u16 val)
-{
-	struct bus *pbus = get_pbus(dev);
-	pci_ops_mmconf.write16(pbus, dev->bus->secondary, dev->path.pci.devfn,
-			       where, val);
-}
-
-void pci_mmio_write_config32(struct device *dev, unsigned int where, u32 val)
-{
-	struct bus *pbus = get_pbus(dev);
-	pci_ops_mmconf.write32(pbus, dev->bus->secondary, dev->path.pci.devfn,
-			       where, val);
-}
-
-#endif
diff --git a/src/include/device/pci_ops.h b/src/include/device/pci_ops.h
index 920475a..3310e10 100644
--- a/src/include/device/pci_ops.h
+++ b/src/include/device/pci_ops.h
@@ -13,14 +13,6 @@ void pci_write_config8(struct device *dev, unsigned int where, u8 val);
 void pci_write_config16(struct device *dev, unsigned int where, u16 val);
 void pci_write_config32(struct device *dev, unsigned int where, u32 val);
 
-#if CONFIG_MMCONF_SUPPORT
-u8 pci_mmio_read_config8(struct device *dev, unsigned int where);
-u16 pci_mmio_read_config16(struct device *dev, unsigned int where);
-u32 pci_mmio_read_config32(struct device *dev, unsigned int where);
-void pci_mmio_write_config8(struct device *dev, unsigned int where, u8 val);
-void pci_mmio_write_config16(struct device *dev, unsigned int where, u16 val);
-void pci_mmio_write_config32(struct device *dev, unsigned int where, u32 val);
-#endif
 #endif
 
 #endif /* PCI_OPS_H */



More information about the coreboot-gerrit mailing list