[coreboot-gerrit] Patch set updated for coreboot: CPU: Move SMM prototypes under x86

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Tue Dec 6 16:12:38 CET 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17732

-gerrit

commit afbb825834d7314e4092916c6ea56b731e1dc0c7
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Tue Dec 6 13:58:56 2016 +0200

    CPU: Move SMM prototypes under x86
    
    Change-Id: Iefbc17dcfcf312338d94b2c2945c7fac3b23bff6
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/arch/x86/include/arch/cpu.h               | 4 ++++
 src/include/cpu/cpu.h                         | 4 ----
 src/mainboard/siemens/sitemp_g1p1/mainboard.c | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h
index faa2375..578bb07 100644
--- a/src/arch/x86/include/arch/cpu.h
+++ b/src/arch/x86/include/arch/cpu.h
@@ -163,6 +163,10 @@ int cpu_cpuid_extended_level(void);
 int cpu_have_cpuid(void);
 int cpu_phys_address_size(void);
 
+void smm_init(void);
+void smm_lock(void);
+void smm_setup_structures(void *gnvs, void *tcg, void *smi1);
+
 #ifndef __SIMPLE_DEVICE__
 
 struct device;
diff --git a/src/include/cpu/cpu.h b/src/include/cpu/cpu.h
index bf622d7..3256a83 100644
--- a/src/include/cpu/cpu.h
+++ b/src/include/cpu/cpu.h
@@ -9,10 +9,6 @@ struct bus;
 void initialize_cpus(struct bus *cpu_bus);
 void asmlinkage secondary_cpu_init(unsigned int cpu_index);
 
-void smm_init(void);
-void smm_lock(void);
-void smm_setup_structures(void *gnvs, void *tcg, void *smi1);
-
 #define __cpu_driver __attribute__ ((used,__section__(".rodata.cpu_driver")))
 #ifndef __SIMPLE_DEVICE__
 /** start of compile time generated pci driver array */
diff --git a/src/mainboard/siemens/sitemp_g1p1/mainboard.c b/src/mainboard/siemens/sitemp_g1p1/mainboard.c
index 736ef34..1f266a7 100644
--- a/src/mainboard/siemens/sitemp_g1p1/mainboard.c
+++ b/src/mainboard/siemens/sitemp_g1p1/mainboard.c
@@ -760,7 +760,7 @@ static void detect_hw_variant( device_t dev )
 	}
 }
 
-static void smm_lock( void )
+void smm_lock(void)
 {
 	/* LOCK the SMM memory window and enable normal SMM.
 	 * After running this function, only a full reset can



More information about the coreboot-gerrit mailing list