[coreboot-gerrit] New patch to review for coreboot: vendorcode/google/chromeos: zero out SHARED_DATA region

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Sat Dec 10 21:04:05 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17789

-gerrit

commit 5757dd8fdfdd4ef2cba69a9c1cce740ad30be035
Author: Patrick Georgi <pgeorgi at google.com>
Date:   Wed Dec 7 12:12:59 2016 +0100

    vendorcode/google/chromeos: zero out SHARED_DATA region
    
    BUG=chromium:595715
    BRANCH=none
    TEST=/build/$board/firmware/coreboot.rom has a zeroed out SHARED_DATA
    region if it exists.
    
    Change-Id: Ib1e6fd62bcf987872890c6d155287dcedb0b1f40
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: e8a88bf744f44d034f8606a556014e2bee37eda1
    Original-Change-Id: I0b59f1f0e2f8645000f83cb3ca7f49e4da726341
    Original-Signed-off-by: Patrick Georgi <pgeorgi at google.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/417821
    Original-Commit-Ready: Patrick Georgi <pgeorgi at chromium.org>
    Original-Tested-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Reviewed-by: Stefan Reinauer <reinauer at chromium.org>
---
 src/vendorcode/google/chromeos/Makefile.inc | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.inc
index cd3831c..e84eb3d 100644
--- a/src/vendorcode/google/chromeos/Makefile.inc
+++ b/src/vendorcode/google/chromeos/Makefile.inc
@@ -107,6 +107,12 @@ build_complete:: $(obj)/gbb.region $(obj)/fwid.region
 	$(CBFSTOOL) $(obj)/coreboot.rom write -u -r RW_FWID_A -i 0 -f $(obj)/fwid.region
 	$(CBFSTOOL) $(obj)/coreboot.rom write -u -r RW_FWID_B -i 0 -f $(obj)/fwid.region
 
+ifneq ($(shell grep "SHARED_DATA" "$(CONFIG_FMDFILE)"),)
+build_complete::
+	printf "\0" > $(obj)/shared_data.region
+	$(CBFSTOOL) $(obj)/coreboot.rom write -u -r SHARED_DATA -i 0 -f $(obj)/shared_data.region
+endif
+
 # Extract FW_MAIN_? region and minimize it if the last file is empty, so it
 # doesn't contain this empty file (that can have a significant size),
 # improving a lot on hash times due to a smaller amount of data loaded from



More information about the coreboot-gerrit mailing list