[coreboot-gerrit] New patch to review for coreboot: arch/x86/smbios.c: re-add SPD manufacturer IDs

Matt DeVillier (matt.devillier@gmail.com) gerrit at coreboot.org
Tue Dec 13 21:22:42 CET 2016


Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17852

-gerrit

commit 463fe4ab5c9466aca81a5f34c37ddd9f21971d6f
Author: Matt DeVillier <matt.devillier at gmail.com>
Date:   Fri Sep 2 21:44:33 2016 -0500

    arch/x86/smbios.c: re-add SPD manufacturer IDs
    
    some manufacturer IDs removed in commit c86da67 are used in the
    SPD data for multiple Chromebooks; removing these IDs breaks RAM
    manufacturer identification in SMBIOS tables for those devices.
    
    Change-Id: I13dd87a8d3d6b23619d22155915a0f807feec97a
    Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
 src/arch/x86/smbios.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 0c7f3ac..9c6873c 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -151,6 +151,7 @@ void smbios_fill_dimm_manufacturer_from_id(uint16_t mod_id, struct smbios_type17
 							    "Kingston");
 			break;
 		case 0xad00:
+		case 0xad80:
 			t->manufacturer = smbios_add_string(t->eos,
 							    "Hynix");
 			break;
@@ -171,6 +172,7 @@ void smbios_fill_dimm_manufacturer_from_id(uint16_t mod_id, struct smbios_type17
 							    "GSkill");
 			break;
 		case 0xce00:
+		case 0xce80:
 			t->manufacturer = smbios_add_string(t->eos,
 							    "Samsung");
 			break;



More information about the coreboot-gerrit mailing list