[coreboot-gerrit] Patch merged into coreboot/master: pcf8523: Fix wrong initialization of several registers
gerrit at coreboot.org
gerrit at coreboot.org
Thu Dec 15 04:11:15 CET 2016
the following patch was just integrated into master:
commit f1f322b1a883e3d50a1907e29b5aa333a0f795a8
Author: Werner Zeh <werner.zeh at siemens.com>
Date: Tue Dec 13 08:03:10 2016 +0100
pcf8523: Fix wrong initialization of several registers
In the case where the RTC is initialized after the battery is
completely drained the bits for power_mode and cof_selection are set up
with wrongly applied masks.
In the case where the RTC is re-initialized again with no power-loss
after the last initialization the bits for cap_sel, power_mode and
cof_selection are not shifted to the right position.
Both errors lead to a wrong initialization of the RTC and in turn to a
way larger current consumption (instead of 120 nA the RTC current rises
to over 2 µA).
This patch fixes both errors and the current consumption is in the right
range again.
TEST=booted mc_bdx1 and verified current consumption of RTC
Change-Id: I8594f6ac121a175844393952db2169dbc5cbd2b2
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
Reviewed-on: https://review.coreboot.org/17829
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth at google.com>
See https://review.coreboot.org/17829 for details.
-gerrit
More information about the coreboot-gerrit
mailing list