[coreboot-gerrit] New patch to review for coreboot: util/romcc: remove self-assignment

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu Dec 15 15:25:45 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17885

-gerrit

commit 5cf7dfb6d534d542229d78d9bfb5601bfaac9c77
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Thu Dec 15 15:17:45 2016 +0100

    util/romcc: remove self-assignment
    
    Change-Id: I0f78b55b28011cdefc90665bca2a7ea17647e955
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1129127
---
 util/romcc/romcc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/util/romcc/romcc.c b/util/romcc/romcc.c
index 655e6f5..7b5e5d7 100644
--- a/util/romcc/romcc.c
+++ b/util/romcc/romcc.c
@@ -20919,7 +20919,6 @@ static void scc_visit_phi(struct compile_state *state, struct scc_state *scc,
 		}
 		/* meet(X, lattice high) = X */
 		else if (is_lattice_hi(state, tmp)) {
-			lnode->val = lnode->val;
 		}
 		/* meet(lattice high, X) = X */
 		else if (is_lattice_hi(state, lnode)) {



More information about the coreboot-gerrit mailing list