[coreboot-gerrit] New patch to review for coreboot: samsung/exynos5420: Fix test for src < 0
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Thu Dec 15 15:52:34 CET 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17888
-gerrit
commit f544dbe12f698556473a31ac85aaff2e8ec86ccd
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Thu Dec 15 15:51:13 2016 +0100
samsung/exynos5420: Fix test for src < 0
It was unsigned, not a good place to be for testing < 0.
Change-Id: I126fe86422900bbae2c3ca16052be27985cfed53
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Found-by: Coverity Scan #1241911
---
src/soc/samsung/exynos5420/clock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/soc/samsung/exynos5420/clock.c b/src/soc/samsung/exynos5420/clock.c
index 49ac07b..3c4bb04 100644
--- a/src/soc/samsung/exynos5420/clock.c
+++ b/src/soc/samsung/exynos5420/clock.c
@@ -161,7 +161,8 @@ static int clock_select_to_pll(enum peripheral_clock_select sel)
unsigned long clock_get_periph_rate(enum periph_id peripheral)
{
unsigned long sclk;
- unsigned int src, div;
+ unsigned int div;
+ int src;
switch (peripheral) {
case PERIPH_ID_UART0:
More information about the coreboot-gerrit
mailing list