[coreboot-gerrit] Patch set updated for coreboot: drivers/i2c/hid: Add generic I2C HID driver

Duncan Laurie (dlaurie@chromium.org) gerrit at coreboot.org
Thu Dec 15 17:34:25 CET 2016


Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17856

-gerrit

commit 369c16ed82a966d9b8dbab1a79c1b1bdc30902cd
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Dec 13 16:43:40 2016 -0800

    drivers/i2c/hid: Add generic I2C HID driver
    
    Add a generic I2C-HID driver for these types of devices that
    do not need extra functionality.  This allows a new device to
    be added without having to write a new driver.
    
    The i2c-hid PNP0C50 is automatically added as the _CID for the
    device in the ACPI Device.
    
    BUG=chrome-os-partner:58666
    TEST=used on eve to describe a new i2c-hid touch controller
    
    Change-Id: I94e9531a72f9bf1d6b3ade362b88883b21b83d0a
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/drivers/i2c/hid/Kconfig      |  3 ++
 src/drivers/i2c/hid/Makefile.inc |  1 +
 src/drivers/i2c/hid/chip.h       | 28 +++++++++++++++++
 src/drivers/i2c/hid/hid.c        | 67 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 99 insertions(+)

diff --git a/src/drivers/i2c/hid/Kconfig b/src/drivers/i2c/hid/Kconfig
new file mode 100644
index 0000000..22531bb
--- /dev/null
+++ b/src/drivers/i2c/hid/Kconfig
@@ -0,0 +1,3 @@
+config DRIVERS_I2C_HID
+	bool
+	select DRIVERS_I2C_GENERIC
diff --git a/src/drivers/i2c/hid/Makefile.inc b/src/drivers/i2c/hid/Makefile.inc
new file mode 100644
index 0000000..12162ac
--- /dev/null
+++ b/src/drivers/i2c/hid/Makefile.inc
@@ -0,0 +1 @@
+ramstage-$(CONFIG_DRIVERS_I2C_HID) += hid.c
diff --git a/src/drivers/i2c/hid/chip.h b/src/drivers/i2c/hid/chip.h
new file mode 100644
index 0000000..7bce167
--- /dev/null
+++ b/src/drivers/i2c/hid/chip.h
@@ -0,0 +1,28 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2016 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef __DRIVERS_I2C_HID_CHIP_H__
+#define __DRIVERS_I2C_HID_CHIP_H__
+
+#include <drivers/i2c/generic/chip.h>
+
+#define I2C_HID_CID	"PNP0C50"
+
+struct drivers_i2c_hid_config {
+	struct drivers_i2c_generic_config generic;
+	uint8_t hid_desc_reg_offset;
+};
+
+#endif /* __I2C_HID_CHIP_H__ */
diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c
new file mode 100644
index 0000000..9eb56c2
--- /dev/null
+++ b/src/drivers/i2c/hid/hid.c
@@ -0,0 +1,67 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2016 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <arch/acpigen_dsm.h>
+#include <device/device.h>
+#include <stdint.h>
+#include <string.h>
+#include "chip.h"
+
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+static void i2c_hid_fill_dsm(struct device *dev)
+{
+	struct drivers_i2c_hid_config *config = dev->chip_info;
+	struct dsm_i2c_hid_config dsm_config = {
+		.hid_desc_reg_offset = config->hid_desc_reg_offset,
+	};
+
+	acpigen_write_dsm_i2c_hid(&dsm_config);
+}
+
+static void i2c_hid_fill_ssdt_generator(struct device *dev)
+{
+	struct drivers_i2c_hid_config *config = dev->chip_info;
+	config->generic.cid = I2C_HID_CID;
+	i2c_generic_fill_ssdt(dev, &i2c_hid_fill_dsm, &config->generic);
+}
+
+static const char *i2c_hid_acpi_name(struct device *dev)
+{
+	static char name[5];
+	snprintf(name, sizeof(name), "H%03.3X", dev->path.i2c.device);
+	name[4] = '\0';
+	return name;
+}
+#endif
+
+static struct device_operations i2c_hid_ops = {
+	.read_resources		  = DEVICE_NOOP,
+	.set_resources		  = DEVICE_NOOP,
+	.enable_resources	  = DEVICE_NOOP,
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+	.acpi_name		  = &i2c_hid_acpi_name,
+	.acpi_fill_ssdt_generator = &i2c_hid_fill_ssdt_generator,
+#endif
+};
+
+static void i2c_hid_enable(struct device *dev)
+{
+	dev->ops = &i2c_hid_ops;
+}
+
+struct chip_operations drivers_i2c_hid_ops = {
+	CHIP_NAME("I2C HID Device")
+	.enable_dev = &i2c_hid_enable
+};



More information about the coreboot-gerrit mailing list