[coreboot-gerrit] Patch set updated for coreboot: soc/intel/apollolake: don't probe flash manually

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Thu Dec 15 17:45:02 CET 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17867

-gerrit

commit 2feb6c356ab2f7ab61255d26cf3ecbd906e601c4
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Dec 14 12:32:35 2016 -0600

    soc/intel/apollolake: don't probe flash manually
    
    Rely on boot_device_spi_flash() to provide the spi_flash
    object. There's no need to duplicate the probing logic.
    
    BUG=chrome-os-partner:56151
    BRANCH=reef
    
    Change-Id: I91900a3dfad7ba92cbd3b0ace77b08db04cff0b6
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/apollolake/romstage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c
index 8c2a1a3..97be0f6 100644
--- a/src/soc/intel/apollolake/romstage.c
+++ b/src/soc/intel/apollolake/romstage.c
@@ -318,9 +318,9 @@ void mainboard_save_dimm_info(void)
 int get_sw_write_protect_state(void)
 {
 	uint8_t status;
-	struct spi_flash *flash;
+	const struct spi_flash *flash;
 
-	flash = spi_flash_probe(CONFIG_BOOT_DEVICE_SPI_FLASH_BUS, 0);
+	flash = boot_device_spi_flash();
 	if (!flash)
 		return 0;
 



More information about the coreboot-gerrit mailing list