[coreboot-gerrit] Patch set updated for coreboot: amd/gardenia: Clean up GPIO ASL
Marshall Dawson (marshalldawson3rd@gmail.com)
gerrit at coreboot.org
Fri Dec 16 19:53:15 CET 2016
Marshall Dawson (marshalldawson3rd at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17846
-gerrit
commit f5d7e94c1bb85cf6a574b6a6a9a40582080c7483
Author: Marshall Dawson <marshalldawson3rd at gmail.com>
Date: Thu Oct 20 12:43:15 2016 -0400
amd/gardenia: Clean up GPIO ASL
Remove the unused Name field. Its previous design generates an FWTS
error and a recommendation for changing it to Serialized.
Original-Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
Original-Reviewed-by: Marc Jones <marcj303 at gmail.com>
(cherry picked from commit 1d970f1aa16c647e56a08c83f5719041882a2fc0)
Change-Id: I27748a4f84286e80043f516564ef64350ef3fef9
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
src/mainboard/amd/gardenia/acpi/carrizo_fch.asl | 30 +++++--------------------
1 file changed, 6 insertions(+), 24 deletions(-)
diff --git a/src/mainboard/amd/gardenia/acpi/carrizo_fch.asl b/src/mainboard/amd/gardenia/acpi/carrizo_fch.asl
index 79f5420..a177306 100644
--- a/src/mainboard/amd/gardenia/acpi/carrizo_fch.asl
+++ b/src/mainboard/amd/gardenia/acpi/carrizo_fch.asl
@@ -1,7 +1,7 @@
/*
* This file is part of the coreboot project.
*
- * Copyright (C) 2015 Advanced Micro Devices, Inc.
+ * Copyright (C) 2015-2016 Advanced Micro Devices, Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -18,31 +18,13 @@ Device(GPIO) {
Name (_CID, "AMD0030")
Name(_UID, 0)
- Method (_CRS, 0x0, NotSerialized) {
- Name (RBUF, ResourceTemplate () {
- //
- // Interrupt resource. In this example, banks 0 & 1 share the same
- // interrupt to the parent controller and similarly banks 2 & 3.
- //
- // N.B. The definition below is chosen for an arbitrary
- // test platform. It needs to be changed to reflect the hardware
- // configuration of the actual platform
- //
- Interrupt(ResourceConsumer, Level, ActiveLow, Shared, , , ) {7}
-
- //
- // Memory resource. The definition below is chosen for an arbitrary
- // test platform. It needs to be changed to reflect the hardware
- // configuration of the actual platform.
- //
- Memory32Fixed(ReadWrite, 0xFED81500, 0x300)
- })
-
- Return (RBUF)
- }
+ Name(_CRS, ResourceTemplate() {
+ Interrupt(ResourceConsumer, Level, ActiveLow, Shared, , , ) {7}
+ Memory32Fixed(ReadWrite, 0xFED81500, 0x300)
+ })
Method (_STA, 0x0, NotSerialized) {
- Return (0x0F)
+ Return (0x0F)
}
}
More information about the coreboot-gerrit
mailing list