[coreboot-gerrit] New patch to review for coreboot: google/auron: Fix omitted ACPI KB backlight for variants

Matt DeVillier (matt.devillier@gmail.com) gerrit at coreboot.org
Fri Dec 23 22:07:44 CET 2016


Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17960

-gerrit

commit 98de2d9c28c8e11fcd75789f1e378e81664f4ac6
Author: Matt DeVillier <matt.devillier at gmail.com>
Date:   Fri Dec 23 14:56:12 2016 -0600

    google/auron: Fix omitted ACPI KB backlight for variants
    
    Restores KB backlight functionality for auron variants
    gandof, lulu, and saumus
    
    TEST: boot Lulu and observe KB backlight functional
    
    Change-Id: Iaa852f9327ff1690111db610b4cc5266cd7925b4
    Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
 src/mainboard/google/auron/acpi/ec.asl                    |  3 +++
 .../variants/auron_paine/include/variant/acpi/ec.asl      |  0
 .../auron/variants/auron_yuna/include/variant/acpi/ec.asl |  0
 .../auron/variants/gandof/include/variant/acpi/ec.asl     | 15 +++++++++++++++
 .../auron/variants/lulu/include/variant/acpi/ec.asl       | 15 +++++++++++++++
 .../auron/variants/samus/include/variant/acpi/ec.asl      | 15 +++++++++++++++
 6 files changed, 48 insertions(+)

diff --git a/src/mainboard/google/auron/acpi/ec.asl b/src/mainboard/google/auron/acpi/ec.asl
index c6cf506..98b34af 100644
--- a/src/mainboard/google/auron/acpi/ec.asl
+++ b/src/mainboard/google/auron/acpi/ec.asl
@@ -16,5 +16,8 @@
 /* mainboard configuration */
 #include "ec.h"
 
+/*variant configuration */
+#include <variant/acpi/ec.asl>
+
 /* ACPI code for EC functions */
 #include <ec/google/chromeec/acpi/ec.asl>
diff --git a/src/mainboard/google/auron/variants/auron_paine/include/variant/acpi/ec.asl b/src/mainboard/google/auron/variants/auron_paine/include/variant/acpi/ec.asl
new file mode 100644
index 0000000..e69de29
diff --git a/src/mainboard/google/auron/variants/auron_yuna/include/variant/acpi/ec.asl b/src/mainboard/google/auron/variants/auron_yuna/include/variant/acpi/ec.asl
new file mode 100644
index 0000000..e69de29
diff --git a/src/mainboard/google/auron/variants/gandof/include/variant/acpi/ec.asl b/src/mainboard/google/auron/variants/gandof/include/variant/acpi/ec.asl
new file mode 100644
index 0000000..12b59b4
--- /dev/null
+++ b/src/mainboard/google/auron/variants/gandof/include/variant/acpi/ec.asl
@@ -0,0 +1,15 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/* Enable EC backed Keyboard Backlight in ACPI */
+#define EC_ENABLE_KEYBOARD_BACKLIGHT
diff --git a/src/mainboard/google/auron/variants/lulu/include/variant/acpi/ec.asl b/src/mainboard/google/auron/variants/lulu/include/variant/acpi/ec.asl
new file mode 100644
index 0000000..12b59b4
--- /dev/null
+++ b/src/mainboard/google/auron/variants/lulu/include/variant/acpi/ec.asl
@@ -0,0 +1,15 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/* Enable EC backed Keyboard Backlight in ACPI */
+#define EC_ENABLE_KEYBOARD_BACKLIGHT
diff --git a/src/mainboard/google/auron/variants/samus/include/variant/acpi/ec.asl b/src/mainboard/google/auron/variants/samus/include/variant/acpi/ec.asl
new file mode 100644
index 0000000..12b59b4
--- /dev/null
+++ b/src/mainboard/google/auron/variants/samus/include/variant/acpi/ec.asl
@@ -0,0 +1,15 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/* Enable EC backed Keyboard Backlight in ACPI */
+#define EC_ENABLE_KEYBOARD_BACKLIGHT



More information about the coreboot-gerrit mailing list