[coreboot-gerrit] Patch set updated for coreboot: sb/nvidia/mcp55: Fix P_state generation

Arthur Heymans (arthur@aheymans.xyz) gerrit at coreboot.org
Fri Dec 30 11:58:07 CET 2016


Arthur Heymans (arthur at aheymans.xyz) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17977

-gerrit

commit b90a2846d1d8a15d0572725a8612e070142f4217
Author: Arthur Heymans <arthur at aheymans.xyz>
Date:   Wed Dec 28 12:35:06 2016 +0100

    sb/nvidia/mcp55: Fix P_state generation
    
    amd_generate_powernow is never called by in lpc_slave_ops.
    Move it to lpc_ops like on all other AMD southbridges.
    
    TESTED on Gigabyte ga-m57sli-s4
    
    Change-Id: I7db036e681d591a19e15dd3eaafb88b72a41bea1
    Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
 src/southbridge/nvidia/mcp55/lpc.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/src/southbridge/nvidia/mcp55/lpc.c b/src/southbridge/nvidia/mcp55/lpc.c
index afc6e64..eeb6c1b 100644
--- a/src/southbridge/nvidia/mcp55/lpc.c
+++ b/src/southbridge/nvidia/mcp55/lpc.c
@@ -240,10 +240,21 @@ static void mcp55_lpc_enable_resources(device_t dev)
 	mcp55_lpc_enable_childrens_resources(dev);
 }
 
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+static void southbridge_acpi_fill_ssdt_generator(device_t device)
+{
+	amd_generate_powernow(0, 0, 0);
+}
+#endif
+
 static struct device_operations lpc_ops = {
 	.read_resources   = mcp55_lpc_read_resources,
 	.set_resources    = pci_dev_set_resources,
 	.enable_resources = mcp55_lpc_enable_resources,
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+	.acpi_fill_ssdt_generator = southbridge_acpi_fill_ssdt_generator,
+	.write_acpi_tables = acpi_write_hpet,
+#endif
 	.init             = lpc_init,
 	.scan_bus         = scan_lpc_bus,
 	.ops_pci          = &mcp55_pci_ops,
@@ -264,21 +275,11 @@ static const struct pci_driver lpc_driver __pci_driver = {
 	.devices = lpc_ids,
 };
 
-#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
-
-static void southbridge_acpi_fill_ssdt_generator(device_t device)
-{
-	amd_generate_powernow(0, 0, 0);
-}
-
-#endif
-
 static struct device_operations lpc_slave_ops = {
 	.read_resources   = mcp55_lpc_read_resources,
 	.set_resources    = pci_dev_set_resources,
 	.enable_resources = pci_dev_enable_resources,
 #if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
-	.acpi_fill_ssdt_generator = southbridge_acpi_fill_ssdt_generator,
 	.write_acpi_tables      = acpi_write_hpet,
 #endif
 	.init             = lpc_slave_init,



More information about the coreboot-gerrit mailing list