[coreboot-gerrit] Patch set updated for coreboot: mainboard/asus/kgpe-d16: Wait for all APs to stop before MCT setup

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Mon Feb 1 03:42:45 CET 2016


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13169

-gerrit

commit 923906ed0cdda96e781e84c4b3b7d764d9dcc833
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Tue Nov 24 14:12:03 2015 -0600

    mainboard/asus/kgpe-d16: Wait for all APs to stop before MCT setup
    
    Under certain conditions when the APs are still executing during
    MCT setup the system can hang.  This was the root cause of most
    of the S3 resume failures on this platform; waiting for AP stop
    before MCT setup allows for reliable S3 resume.
    
    Change-Id: I329eea9a8912d7b57efe6aae327d24fd6c3fd782
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/mainboard/asus/kgpe-d16/romstage.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/mainboard/asus/kgpe-d16/romstage.c b/src/mainboard/asus/kgpe-d16/romstage.c
index 89183cc..1904bc2 100644
--- a/src/mainboard/asus/kgpe-d16/romstage.c
+++ b/src/mainboard/asus/kgpe-d16/romstage.c
@@ -515,6 +515,10 @@ void cache_as_ram_main(unsigned long bist, unsigned long cpu_init_detectedx)
 
 	post_code(0x3B);
 
+	/* Wait for all APs to be stopped, otherwise ram initialization may hang */
+	if (IS_ENABLED(CONFIG_LOGICAL_CPUS))
+		wait_all_other_cores_stopped(bsp_apicid);
+
 	/* It's the time to set ctrl in sysinfo now; */
 	printk(BIOS_DEBUG, "fill_mem_ctrl() detected %d nodes\n", sysinfo->nodes);
 	if (is_fam15h())



More information about the coreboot-gerrit mailing list