[coreboot-gerrit] New patch to review for coreboot: iasl: Disable warning 3144 when compiling with warnings as errors.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Wed Feb 3 11:58:21 CET 2016


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13570

-gerrit

commit d30bae730804ba21de721fa9fd544c5d25a26303
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Wed Feb 3 11:55:08 2016 +0100

    iasl: Disable warning 3144 when compiling with warnings as errors.
    
    Warning 3144 is "assigned but not used variable". Yet often we need to read
    registers to trigger some side effect and don't care about the actual value.
    To implement this we dump result into variable we don't use afterwards.
    
    Change-Id: Ic824c7b7c8469fd3c6cf673f50f54557fb363fbd
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index 175b08b..76a9b93 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -205,7 +205,7 @@ $(obj)/$(1).aml: $(src)/mainboard/$(MAINBOARDDIR)/$(1).asl $(obj)/config.h
 	@printf "    IASL       $$(subst $(top)/,,$$(@))\n"
 	$(CC_ramstage) -x assembler-with-cpp -E -MMD -MT $$(@) $$(CPPFLAGS_ramstage) -D__ACPI__ -P -include $(src)/include/kconfig.h -I$(obj) -I$(src) -I$(src)/include -I$(src)/arch/$(ARCHDIR-$(ARCH-ramstage-y))/include -I$(src)/mainboard/$(MAINBOARDDIR) $$< -o $$@
 ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),y)
-	cd $$(dir $$@); $(IASL) -we -p $$(notdir $$@) $$(notdir $$@)
+	cd $$(dir $$@); $(IASL) -we -vw3144 -p $$(notdir $$@) $$(notdir $$@)
 else
 	cd $$(dir $$@); $(IASL) -p $$(notdir $$@) $$(notdir $$@)
 endif



More information about the coreboot-gerrit mailing list