[coreboot-gerrit] New patch to review for coreboot: ASL: Fix HPBA shadowing.

Vladimir Serbinenko (phcoder@gmail.com) gerrit at coreboot.org
Mon Feb 8 00:11:29 CET 2016


Vladimir Serbinenko (phcoder at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13622

-gerrit

commit 01fc9d516df2d1ddf10e400610e4c0875c3fe20a
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Mon Feb 8 00:08:49 2016 +0100

    ASL: Fix HPBA shadowing.
    
    Store (HPBA, HPBA) had no effect. Rename one of HPBA to avoid shadowing.
    
    Change-Id: I54bfa7bcb3e05c28fe8a257825af56527dbf663e
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>
---
 src/mainboard/advansus/a785e-i/dsdt.asl       | 4 ++--
 src/mainboard/amd/bimini_fam10/dsdt.asl       | 4 ++--
 src/mainboard/amd/mahogany/dsdt.asl           | 4 ++--
 src/mainboard/amd/mahogany_fam10/dsdt.asl     | 4 ++--
 src/mainboard/amd/tilapia_fam10/dsdt.asl      | 4 ++--
 src/mainboard/amd/torpedo/dsdt.asl            | 4 ++--
 src/mainboard/asrock/939a785gmh/dsdt.asl      | 4 ++--
 src/mainboard/asus/m4a78-em/dsdt.asl          | 4 ++--
 src/mainboard/asus/m4a785-m/dsdt.asl          | 4 ++--
 src/mainboard/asus/m5a88-v/dsdt.asl           | 4 ++--
 src/mainboard/avalue/eax-785e/dsdt.asl        | 4 ++--
 src/mainboard/gigabyte/ma785gm/dsdt.asl       | 4 ++--
 src/mainboard/gigabyte/ma785gmt/dsdt.asl      | 4 ++--
 src/mainboard/gigabyte/ma78gm/dsdt.asl        | 4 ++--
 src/mainboard/iei/kino-780am2-fam10/dsdt.asl  | 4 ++--
 src/mainboard/jetway/pa78vm5/dsdt.asl         | 4 ++--
 src/mainboard/lippert/frontrunner-af/dsdt.asl | 4 ++--
 src/mainboard/lippert/toucan-af/dsdt.asl      | 4 ++--
 src/mainboard/supermicro/h8scm_fam10/dsdt.asl | 4 ++--
 19 files changed, 38 insertions(+), 38 deletions(-)

diff --git a/src/mainboard/advansus/a785e-i/dsdt.asl b/src/mainboard/advansus/a785e-i/dsdt.asl
index 03fc82d..9dfdbb1 100644
--- a/src/mainboard/advansus/a785e-i/dsdt.asl
+++ b/src/mainboard/advansus/a785e-i/dsdt.asl
@@ -1453,8 +1453,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/amd/bimini_fam10/dsdt.asl b/src/mainboard/amd/bimini_fam10/dsdt.asl
index ec1e60e..ff92d36 100644
--- a/src/mainboard/amd/bimini_fam10/dsdt.asl
+++ b/src/mainboard/amd/bimini_fam10/dsdt.asl
@@ -1459,8 +1459,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/amd/mahogany/dsdt.asl b/src/mainboard/amd/mahogany/dsdt.asl
index 5602368..e252454 100644
--- a/src/mainboard/amd/mahogany/dsdt.asl
+++ b/src/mainboard/amd/mahogany/dsdt.asl
@@ -1386,8 +1386,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/amd/mahogany_fam10/dsdt.asl b/src/mainboard/amd/mahogany_fam10/dsdt.asl
index afc3823..df7a9ee 100644
--- a/src/mainboard/amd/mahogany_fam10/dsdt.asl
+++ b/src/mainboard/amd/mahogany_fam10/dsdt.asl
@@ -1428,8 +1428,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/amd/tilapia_fam10/dsdt.asl b/src/mainboard/amd/tilapia_fam10/dsdt.asl
index daf912d..01fc046 100644
--- a/src/mainboard/amd/tilapia_fam10/dsdt.asl
+++ b/src/mainboard/amd/tilapia_fam10/dsdt.asl
@@ -1428,8 +1428,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/amd/torpedo/dsdt.asl b/src/mainboard/amd/torpedo/dsdt.asl
index 2a13c3e..8926966 100644
--- a/src/mainboard/amd/torpedo/dsdt.asl
+++ b/src/mainboard/amd/torpedo/dsdt.asl
@@ -1044,8 +1044,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/asrock/939a785gmh/dsdt.asl b/src/mainboard/asrock/939a785gmh/dsdt.asl
index 2f85650..c81bdf7 100644
--- a/src/mainboard/asrock/939a785gmh/dsdt.asl
+++ b/src/mainboard/asrock/939a785gmh/dsdt.asl
@@ -605,8 +605,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/asus/m4a78-em/dsdt.asl b/src/mainboard/asus/m4a78-em/dsdt.asl
index 28c8c4a..1a88d5b 100644
--- a/src/mainboard/asus/m4a78-em/dsdt.asl
+++ b/src/mainboard/asus/m4a78-em/dsdt.asl
@@ -1428,8 +1428,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/asus/m4a785-m/dsdt.asl b/src/mainboard/asus/m4a785-m/dsdt.asl
index 28c8c4a..1a88d5b 100644
--- a/src/mainboard/asus/m4a785-m/dsdt.asl
+++ b/src/mainboard/asus/m4a785-m/dsdt.asl
@@ -1428,8 +1428,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/asus/m5a88-v/dsdt.asl b/src/mainboard/asus/m5a88-v/dsdt.asl
index f9a1758..6f02e8b 100644
--- a/src/mainboard/asus/m5a88-v/dsdt.asl
+++ b/src/mainboard/asus/m5a88-v/dsdt.asl
@@ -1459,8 +1459,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/avalue/eax-785e/dsdt.asl b/src/mainboard/avalue/eax-785e/dsdt.asl
index fd29b80..c6ced3d 100644
--- a/src/mainboard/avalue/eax-785e/dsdt.asl
+++ b/src/mainboard/avalue/eax-785e/dsdt.asl
@@ -1453,8 +1453,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/gigabyte/ma785gm/dsdt.asl b/src/mainboard/gigabyte/ma785gm/dsdt.asl
index 091d08e..3c53579 100644
--- a/src/mainboard/gigabyte/ma785gm/dsdt.asl
+++ b/src/mainboard/gigabyte/ma785gm/dsdt.asl
@@ -1428,8 +1428,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/gigabyte/ma785gmt/dsdt.asl b/src/mainboard/gigabyte/ma785gmt/dsdt.asl
index 091d08e..3c53579 100644
--- a/src/mainboard/gigabyte/ma785gmt/dsdt.asl
+++ b/src/mainboard/gigabyte/ma785gmt/dsdt.asl
@@ -1428,8 +1428,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/gigabyte/ma78gm/dsdt.asl b/src/mainboard/gigabyte/ma78gm/dsdt.asl
index 091d08e..3c53579 100644
--- a/src/mainboard/gigabyte/ma78gm/dsdt.asl
+++ b/src/mainboard/gigabyte/ma78gm/dsdt.asl
@@ -1428,8 +1428,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl
index 09ce655..a8bb5da 100644
--- a/src/mainboard/iei/kino-780am2-fam10/dsdt.asl
+++ b/src/mainboard/iei/kino-780am2-fam10/dsdt.asl
@@ -1428,8 +1428,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/jetway/pa78vm5/dsdt.asl b/src/mainboard/jetway/pa78vm5/dsdt.asl
index 507ef3b..dc401bb 100644
--- a/src/mainboard/jetway/pa78vm5/dsdt.asl
+++ b/src/mainboard/jetway/pa78vm5/dsdt.asl
@@ -1428,8 +1428,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl
index 9e3b39c..5de4310 100644
--- a/src/mainboard/lippert/frontrunner-af/dsdt.asl
+++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl
@@ -1459,8 +1459,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/lippert/toucan-af/dsdt.asl b/src/mainboard/lippert/toucan-af/dsdt.asl
index 8623aae..525a45e 100644
--- a/src/mainboard/lippert/toucan-af/dsdt.asl
+++ b/src/mainboard/lippert/toucan-af/dsdt.asl
@@ -1459,8 +1459,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */
diff --git a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl
index dfe1076..5268be7 100644
--- a/src/mainboard/supermicro/h8scm_fam10/dsdt.asl
+++ b/src/mainboard/supermicro/h8scm_fam10/dsdt.asl
@@ -1464,8 +1464,8 @@ DefinitionBlock (
 						Return(0x0F) /* sata is visible */
 					}
 					Method(_CRS, 0)	{
-						CreateDwordField(CRS, ^HPT._BAS, HPBA)
-						Store(HPBA, HPBA)
+						CreateDwordField(CRS, ^HPT._BAS, HPBX)
+						Store(HPBA, HPBX)
 						Return(CRS)
 					}
 				} /* End Device(_SB.PCI0.LpcIsaBr.COPR) */



More information about the coreboot-gerrit mailing list