[coreboot-gerrit] Patch set updated for coreboot: soc/intel/quark: FSP MemoryInit Support

Leroy P Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Tue Feb 9 16:58:22 CET 2016


Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13447

-gerrit

commit b21bbba7eb7c931488f7c597c1b3386281ca0650
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Sun Feb 7 14:48:53 2016 -0800

    soc/intel/quark: FSP MemoryInit Support
    
    Add a dummy fill_power_state routine so that execution is able to reach
    FSP MemoryInit.
    
    Testing on Galileo:
    *  Edit the src/mainboard/intel/galileo/Makefile.inc file
       *  Add "select ADD_FSP_PDAT_FILE"
       *  Add "select ADD_FSP_RAW_BIN"
       *  Add "select ADD_RMU_FILE"
       *  Add "select DISPLAY_HOBS"
       *  Add "select DISPLAY_UPD_DATA"
    *  Place the FSP.bin file in the location specified by CONFIG_FSP_FILE
    *  Place the pdat.bin files in the location specified by
        CONFIG_FSP_PDAT_FILE
    *  Place the rmu.bin file in the location specified by CONFIG_RMU_FILE
    *  Testing is successful if:
       *  MemoryInit returns 0 (success) and
       *  The the message "ERROR - Coreboot's requirements not met by FSP
    binary!" is not displayed
    
    Change-Id: I2a116e1e769ac09915638aa9e5d7c58a4aac3cce
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/soc/intel/quark/romstage/romstage.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src/soc/intel/quark/romstage/romstage.c b/src/soc/intel/quark/romstage/romstage.c
index 0951b81..19d0642 100644
--- a/src/soc/intel/quark/romstage/romstage.c
+++ b/src/soc/intel/quark/romstage/romstage.c
@@ -14,9 +14,12 @@
  * GNU General Public License for more details.
  */
 
+#include <arch/early_variables.h>
+#include <console/console.h>
 #include <fsp/car.h>
 #include <soc/iomap.h>
 #include <soc/pci_devs.h>
+#include <soc/pm.h>
 #include <soc/romstage.h>
 
 void car_soc_pre_console_init(void)
@@ -25,3 +28,14 @@ void car_soc_pre_console_init(void)
 		set_base_address_and_enable_uart(0, HSUART1_DEV, HSUART1_FUNC,
 			UART_BASE_ADDRESS);
 }
+
+static struct chipset_power_state power_state CAR_GLOBAL;
+
+struct chipset_power_state *fill_power_state(void)
+{
+	struct chipset_power_state *ps = car_get_var_ptr(&power_state);
+
+	ps->prev_sleep_state = 0;
+	printk(BIOS_DEBUG, "prev_sleep_state %d\n", ps->prev_sleep_state);
+	return ps;
+}



More information about the coreboot-gerrit mailing list