[coreboot-gerrit] Patch merged into coreboot/master: superio/nuvoton/nct5572d: Add PS/2 presence detect

gerrit at coreboot.org gerrit at coreboot.org
Tue Feb 9 20:34:22 CET 2016


the following patch was just integrated into master:
commit bf725b48f730b5996cf1ee7e5ac84ebc0ec78460
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Feb 7 22:14:29 2016 +0100

    superio/nuvoton/nct5572d: Add PS/2 presence detect
    
    On certain Super I/O devices, when a PS/2 mouse is not present on the
    auxiliary channel both channels will cease to function if the
    auxiliary channel is probed while the primary channel is active.
    Therefore, knowledge of mouse presence must be gathered by coreboot
    during early boot, and used to enable or disable the auxiliary PS/2
    port before control is passed to the operating system.
    
    This is added in commit 448e3863 (drivers/pc80: Add PS/2 mouse
    presence detect).
    
    Update the Nuvoton NCT5572D driver to flag the auxiliary channel as
    disabled if no device was detected. The code is copied from the Winbond
    W83667HG-A driver.
    
    Note, the ACPI changes are not part of this commit.
    
    TEST=Currently, on the ASRock E350M1, PS/2 does not work. With this
    change, a PS/2 keyboard works fine in SeaBIOS, GRUB in MBR, and Debian
    GNU/Linux Sid/unstable with Linux 3.19.
    
    ```
    [    1.185195] i8042: PNP: No PS/2 controller found. Probing ports directly.
    [    1.189110] serio: i8042 KBD port at 0x60,0x64 irq 1
    [    1.189133] serio: i8042 AUX port at 0x60,0x64 irq 12
    [    1.189970] mousedev: PS/2 mouse device common for all mice
    ```
    
    Change-Id: I7f9be348d295e70437bef089d4c2173169f38459
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: https://review.coreboot.org/13618
    Tested-by: build bot (Jenkins)
    Reviewed-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/13618 for details.

-gerrit



More information about the coreboot-gerrit mailing list