[coreboot-gerrit] Patch merged into coreboot/master: device/pci_rom: Rename missleading ON_DEVICE_ROM_RUN

gerrit at coreboot.org gerrit at coreboot.org
Tue Feb 16 22:44:09 CET 2016


the following patch was just integrated into master:
commit 647e34dbe547bcd7bb3990d138b5c6906ea935e8
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Thu Feb 11 08:36:50 2016 +0100

    device/pci_rom: Rename missleading ON_DEVICE_ROM_RUN
    
    The Kconfig option "ON_DEVICE_ROM_RUN" suggests that PCI Option ROMs
    are run, but in fact it only controls the loading of PCI based
    Option ROMs.
    
    At the moment coreboot only executes Option ROMs if they are
    VGA Options ROMs and the VGA Option ROM execution flag is enabled.
    Setting ON_DEVICE_ROM_RUN with VGA Option ROM execution disabled
    has no effect.
    
    Clarify that this flag controls the loading behaviour and not the
    execution behaviour.
    
    Change-Id: Ie3e503cb145f9b7ce613755e60ac0f6c00f2bcdb
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
    Reviewed-on: https://review.coreboot.org/13684
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See https://review.coreboot.org/13684 for details.

-gerrit



More information about the coreboot-gerrit mailing list