[coreboot-gerrit] Patch set updated for coreboot: kconfig_lint: check for referenced files if warnings are enabled

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Fri Feb 19 18:27:11 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13751

-gerrit

commit 11d20abe7887f8c97228babe4d40cf1b7c839287
Author: Martin Roth <martinroth at google.com>
Date:   Fri Feb 19 10:24:25 2016 -0700

    kconfig_lint: check for referenced files if warnings are enabled
    
    The builders are having problems running the 'find' function used in
    this check.  Since the builders don't check for warnings, just errors,
    and this check is only for warnings, by disabling the test if warnings
    are disabled, we fix the builders without losing any functionality
    of the test.
    
    Change-Id: I8d1e1c32275f759d085759fb5d8a6c85d4f99539
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/lint/kconfig_lint | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index b5a62d3..33aef02 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -77,7 +77,12 @@ sub Main {
     build_and_parse_kconfig_tree("$root_dir/Kconfig");
 
     #run checks based on the data that was found
-    find( \&check_if_file_referenced, $root_dir );
+    unless ($suppress_warning_output) {
+        # This is causing issues on the build servers.
+        # By only running this if warnings are enabled, this saves
+        # a bit of time, and prevents the error on the build servers.
+        find( \&check_if_file_referenced, $root_dir );
+    }
 
     load_config($config_file) if ($config_file);
 



More information about the coreboot-gerrit mailing list