[coreboot-gerrit] Patch set updated for coreboot: abuild: Use 12 lines of context for errors

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Wed Feb 24 00:42:33 CET 2016


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12720

-gerrit

commit 92b6eeb0ac3427b38b4fdfa6effe5d4199da756c
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Mon Dec 14 16:36:45 2015 -0800

    abuild: Use 12 lines of context for errors
    
    The current default of 6 lines leaves us with no context
    about the actual error:
    
    *** ERROR: 3 warnings encountered, and warnings are errors.
    
    coreboot-gerrit/util/kconfig/Makefile:38: recipe for target 'oldconfig' failed
    make[1]: *** [oldconfig] Error 1
    make[1]: Leaving directory 'coreboot-gerrit'
    
    Change-Id: I67e7d740e7b3b1c66005dc1bf50557a20bc15428
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 util/abuild/abuild | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/util/abuild/abuild b/util/abuild/abuild
index cddcb57..ebd1842 100755
--- a/util/abuild/abuild
+++ b/util/abuild/abuild
@@ -40,7 +40,7 @@ if [ -d "$XGCCPATH" ] && [[ ":$PATH:" != *":$XGCCPATH:"* ]]; then
 fi
 
 # Lines of error context to be printed in FAILURE case
-CONTEXT=6
+CONTEXT=12
 
 # Configure-only mode
 configureonly=0
@@ -223,7 +223,6 @@ function create_config
 		if [ "$quiet" == "false" ]; then printf "  $MAINBOARD config created.\n"; fi
 		return 0
 	else
-		# Does this ever happen?
 		if [ "$quiet" == "false" ]; then printf "$MAINBOARD config creation FAILED!\nLog excerpt:\n"; fi
 		tail -n $CONTEXT $build_dir/config.log 2> /dev/null || tail -$CONTEXT $build_dir/config.log
 		return 1



More information about the coreboot-gerrit mailing list