[coreboot-gerrit] Patch merged into coreboot/master: Revert "cbfstool: Silence LZ4 -Wsign-compare warnings"

gerrit at coreboot.org gerrit at coreboot.org
Wed Feb 24 19:27:24 CET 2016


the following patch was just integrated into master:
commit 8b831da586ef69be790deee1602ea08edad5415a
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue Feb 23 19:19:20 2016 +0100

    Revert "cbfstool: Silence LZ4 -Wsign-compare warnings"
    
    This reverts commit 17cb0370a70ccfc2301b7974bf38d44c7271afea.
    
    It’s the wrong thing to do, to just disable the warning. The code is
    fixed for 32-bit user space now in Change-Id
    I85bee25a69c432ef8bb934add7fd2e2e31f03662 (commonlib/lz4_wrapper: Use
    correct casts to ensure valid calculations), so enable the warning
    again.
    
    Change-Id: I6d1c62c7b4875da8053c25e640c03cedf0ff2916
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: https://review.coreboot.org/13772
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Tested-by: build bot (Jenkins)


See https://review.coreboot.org/13772 for details.

-gerrit



More information about the coreboot-gerrit mailing list