[coreboot-gerrit] New patch to review for coreboot: xcompile: More updates on ARM64 Erratum flags
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Thu Jan 7 22:59:06 CET 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12858
-gerrit
commit f0215c0669decb3b7a099d2b5459ece89d758885
Author: Martin Roth <martinroth at google.com>
Date: Thu Jan 7 14:57:26 2016 -0700
xcompile: More updates on ARM64 Erratum flags
I tried to handle the checking for the config flag internal to xcompile,
but the config flags don't appear to have been loaded into the
environment by make at that point.
This does update the if to check if the flag is even set before putting
anything into .xcompile though. If the LDFLAG isn't set, there's no
point in appending anything.
Also removes the LP version of the erratum config flag, which was a
copy/paste mistake from $(CONFIG_LP_COMPILER_GCC).
Change-Id: I3d8b0328c85310393a120741a498bc18867a6f54
Signed-off-by: Martin Roth <martinroth at google.com>
---
util/xcompile/xcompile | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index b3dd074..a1856e4 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -231,15 +231,16 @@ AS_${TARCH}:=${GCCPREFIX}as ${ASFLAGS}
LD_${TARCH}:=${GCCPREFIX}ld${LINKER_SUFFIX} ${LDFLAGS}
EOF
- if [ "${TARCH}" = "arm64" ]; then
- cat <<EOF
+ if [ "${TARCH}" = "arm64" ] && \
+ [ -n "${LDFLAGS_ARM64_A53_ERRATUM_843419}" ]; then
+ cat <<EOF
-ifeq (\$(CONFIG_ARM64_A53_ERRATUM_843419)\$(CONFIG_LP_ARM64_A53_ERRATUM_843419),y)
+ifeq (\$(CONFIG_ARM64_A53_ERRATUM_843419),y)
LD_${TARCH}+=${LDFLAGS_ARM64_A53_ERRATUM_843419}
endif
EOF
- fi # if [ "${TARCH}" = "arm64" ]
+ fi # if [ "${TARCH}" = "arm64" ]...
cat <<EOF
NM_${TARCH}:=${GCCPREFIX}nm
More information about the coreboot-gerrit
mailing list