[coreboot-gerrit] Patch set updated for coreboot: mainboard/apollolake_rvp: Configure GPIOs earlier, in .init
Alexandru Gagniuc (mr.nuke.me@gmail.com)
gerrit at coreboot.org
Mon Jan 25 18:04:14 CET 2016
Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13380
-gerrit
commit 314f76ec68c3e67cdcf241e4296addbe24004460
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Wed Dec 9 16:54:41 2015 -0800
mainboard/apollolake_rvp: Configure GPIOs earlier, in .init
The .init function gets called very early on, as opposed to
.enable_dev, which will get called after resource allocation. Moving
GPIO configuration to mainboard .init gives it precedence over the
SOC .init, and therefore is called before fsp_silicon_init().
Change-Id: I7cc62d11f8c49c9eb77f75a307fe47374744e3eb
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
src/mainboard/intel/apollolake_rvp/mainboard.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/intel/apollolake_rvp/mainboard.c b/src/mainboard/intel/apollolake_rvp/mainboard.c
index e82f4a5..b437f74 100644
--- a/src/mainboard/intel/apollolake_rvp/mainboard.c
+++ b/src/mainboard/intel/apollolake_rvp/mainboard.c
@@ -22,11 +22,11 @@ static const struct pad_config aplk_rvp_gpios[] = {
PAD_CFG_NF(GPIO_195, NATIVE, DEEP, NF1), /* PANEL0_BKLTCTL */
};
-static void mainboard_enable(struct device *dev)
+static void mainboard_init(void *chip_info)
{
gpio_configure_pads(aplk_rvp_gpios, ARRAY_SIZE(aplk_rvp_gpios));
}
struct chip_operations mainboard_ops = {
- .enable_dev = mainboard_enable,
+ .init = mainboard_init,
};
More information about the coreboot-gerrit
mailing list