[coreboot-gerrit] Patch set updated for coreboot: Makefile.inc: error if UPDATE_IMAGE is enabled with no coreboot.rom
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Mon Jan 25 23:37:30 CET 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13065
-gerrit
commit 68eb22e4bd5c0df8b6af90ecbf4d9824813d4455
Author: Martin Roth <martinroth at google.com>
Date: Wed Jan 20 14:54:27 2016 -0700
Makefile.inc: error if UPDATE_IMAGE is enabled with no coreboot.rom
Instead of just failing with the statement:
'mv: cannot stat ‘coreboot.rom’: No such file or directory',
fail with an error that helps the user understand the issue.
Change-Id: Ie693d45710f599991514e0803a7c444636e473c9
Signed-off-by: Martin Roth <martinroth at google.com>
---
Makefile.inc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Makefile.inc b/Makefile.inc
index 8bf0ca5..5f98864 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -782,7 +782,10 @@ prebuild-files = \
.PHONY: $(obj)/coreboot.pre
$(obj)/coreboot.pre: $$(prebuilt-files) $(CBFSTOOL)
- mv $(obj)/coreboot.rom $@.tmp
+ mv $(obj)/coreboot.rom $@.tmp || \
+ (echo "Error: You have UPDATE_IMAGE set in Kconfig, but have no existing image to update." && \
+ echo Exiting." && \
+ false)
$(prebuild-files) true
mv $@.tmp $@
endif # ifneq ($(CONFIG_UPDATE_IMAGE),y)
More information about the coreboot-gerrit
mailing list