[coreboot-gerrit] Patch set updated for coreboot: intel/strago: Get Boot Flash Write Protect status
Hannah Williams (hannah.williams@intel.com)
gerrit at coreboot.org
Tue Jan 26 01:54:48 CET 2016
Hannah Williams (hannah.williams at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13186
-gerrit
commit d06d5677852d13356a576910dd6172fd16214935
Author: Hannah Williams <hannah.williams at intel.com>
Date: Fri Jan 22 23:04:05 2016 -0800
intel/strago: Get Boot Flash Write Protect status
Read GPIO to get the status
Change-Id: Id2d56ce4b47c4cccba2de3f113afaee6c49885c9
Signed-off-by: Hannah Williams <hannah.williams at intel.com>
---
src/mainboard/intel/strago/chromeos.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/src/mainboard/intel/strago/chromeos.c b/src/mainboard/intel/strago/chromeos.c
index 969021c..741933f 100755
--- a/src/mainboard/intel/strago/chromeos.c
+++ b/src/mainboard/intel/strago/chromeos.c
@@ -23,12 +23,11 @@
#include <ec/google/chromeec/ec.h>
#endif
#include <rules.h>
-#include <soc/gpio.h>
+#include <gpio.h>
#include <string.h>
#include <vendorcode/google/chromeos/chromeos.h>
-/* The WP status pin lives on GPIO_SSUS_6 which is pad 36 in the SUS well. */
-#define WP_STATUS_PAD 36
+#define WP_GPIO GP_E_22
#if ENV_RAMSTAGE
#include <boot/coreboot_tables.h>
@@ -115,15 +114,14 @@ int get_write_protect_state(void)
{
/*
* The vboot loader queries this function in romstage. The GPIOs have
- * not been set up yet as that configuration is done in ramstage. The
- * hardware defaults to an input but there is a 20K pulldown. Externally
- * there is a 10K pullup. Disable the internal pull in romstage so that
- * there isn't any ambiguity in the reading.
+ * not been set up yet as that configuration is done in ramstage.
+ * Configuring this GPIO as input so that there isn't any ambiguity
+ * in the reading.
*/
#if ENV_ROMSTAGE
- ssus_disable_internal_pull(WP_STATUS_PAD);
+ gpio_input_pullup(WP_GPIO);
#endif
/* WP is enabled when the pin is reading high. */
- return ssus_get_gpio(WP_STATUS_PAD);
+ return !!gpio_get(WP_GPIO);
}
More information about the coreboot-gerrit
mailing list