[coreboot-gerrit] New patch to review for coreboot: kconfig_ling: Add warning if tristate type is used in coreboot
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Tue Jan 26 04:17:53 CET 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13460
-gerrit
commit e320cd2b73cc29cb792405a89e168e2baf49ddba
Author: Martin Roth <martinroth at google.com>
Date: Mon Jan 25 16:39:32 2016 -0700
kconfig_ling: Add warning if tristate type is used in coreboot
Although there's no reason we COULDN"T use tristate types, we haven't
up to this point. If there's a good reason to use them in the future,
this check can be removed.
Change-Id: I5f1903341f522bc957e394bc0fd288ba1adab431
Signed-off-by: Martin Roth <martinroth at google.com>
---
util/lint/kconfig_lint | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint
index 9384336..8bdca8d 100755
--- a/util/lint/kconfig_lint
+++ b/util/lint/kconfig_lint
@@ -949,6 +949,10 @@ sub handle_type {
my $expression;
( $type, $expression ) = handle_if_line( $type, $inside_config, $filename, $line_no );
+ if ( $type =~ /tristate/ ) {
+ show_warning("$filename:$line_no - tristate types are not used.");
+ }
+
if ($inside_config) {
if ( exists( $symbols{$inside_config}{type} ) ) {
if ( $symbols{$inside_config}{type} !~ /$type/ ) {
More information about the coreboot-gerrit
mailing list