[coreboot-gerrit] New patch to review for coreboot: arch/arm64: Override bl31 timestamp with coreboot build timestamp
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Thu Jan 28 15:02:34 CET 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13497
-gerrit
commit 74c5e18daed200eb37f51ab29eb2e453bdf0857b
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Thu Jan 28 15:00:54 2016 +0100
arch/arm64: Override bl31 timestamp with coreboot build timestamp
If coreboot's build process is reproducible (eg. using the latest git
timestamp as source), bl31 is, too.
This requires an arm-trusted-firmware side merge first (in progress) and
an update of our reference commit for the submodule, but it also doesn't
hurt anything because it merely sets a variable that currently goes
unused.
Change-Id: If139538a2fab5b3a70c67f4625aa2596532308f7
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
---
src/arch/arm64/Makefile.inc | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/arch/arm64/Makefile.inc b/src/arch/arm64/Makefile.inc
index 33755d3..ec559fa 100644
--- a/src/arch/arm64/Makefile.inc
+++ b/src/arch/arm64/Makefile.inc
@@ -155,12 +155,18 @@ endif # CONFIG_CONSOLE_SERIAL
# Avoid build/release|build/debug distinction by overriding BUILD_PLAT directly
BL31_MAKEARGS += BUILD_PLAT="$(abspath $(obj)/3rdparty/arm-trusted-firmware)"
+# Set a consistent build timestamp: the same coreboot has
+# The \# \" complications exist to satisfy both gnu make's parser and editors
+# with non-semantic quote-handling (that would assume that this line starts a
+# multi line string.
+BL31_MAKEARGS += BUILD_MESSAGE_TIMESTAMP="$(shell grep "\#define COREBOOT_BUILD\>" $(obj)/build.h |cut -d\" -f2 \# \")"
+
BL31_CFLAGS := -fno-pic -fno-stack-protector
BL31_LDFLAGS := --emit-relocs
BL31 := $(obj)/bl31.elf
-$(BL31):
+$(BL31): $(obj)/build.h
@printf " MAKE $(subst $(obj)/,,$(@))\n"
CROSS_COMPILE="$(CROSS_COMPILE_arm64)" \
CFLAGS="$(BL31_CFLAGS)" \
More information about the coreboot-gerrit
mailing list