[coreboot-gerrit] Patch merged into coreboot/master: soc/braswell/acpi/DPTF: Write TCHG state on AC connect.
gerrit at coreboot.org
gerrit at coreboot.org
Thu Jan 28 20:45:35 CET 2016
the following patch was just integrated into master:
commit 01be52eca9c1c207613c8d4070a1982ddac9af2f
Author: Jenny TC <jenny.tc at intel.com>
Date: Fri Jul 24 15:04:06 2015 +0530
soc/braswell/acpi/DPTF: Write TCHG state on AC connect.
DPTF should update the charger cooling device state during
boot time and every 3 seconds after boot. But 3 seconds polling
doesn't seems to be working with current version of DPTF.
This impacts charging since DPTF writes states 4 when charger
is not connected at boot time. On connecting the charger,
DPTF doesn't write 0 to enable charging. This issue is addressed
by calling the PPPC function to read cooling device state and passing
the value to SPPC to set cooling device state. This doesn't
compromise safety since DPTF can override this value
later based on the platform thermal condition. Also this provides
additional safety measure in the unlikely event that DPTF crashes
and is not re-spawned by OS. With this patch even after DPTF crashes,
if the power adapter is plugged it would still allow the system to
charge correctly.
Original-Reviewed-on: https://chromium-review.googlesource.com/288460
Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Original-Tested-by: Jenny Tc <jenny.tc at intel.com>
Change-Id: I50c7666b86e45d5ab537a9d4149e6c71eba04e50
Signed-off-by: Hannah Williams <hannah.williams at intel.com>
Reviewed-on: https://review.coreboot.org/12729
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth at google.com>
See https://review.coreboot.org/12729 for details.
-gerrit
More information about the coreboot-gerrit
mailing list