[coreboot-gerrit] New patch to review for coreboot: intel/x4x: Do not use scratchpad register for ACPI S3

[Kyösti Mälkki (kyosti.malkki@gmail.com)]

Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15716

-gerrit

commit e2b2168fa4c8b8edaa7e93a14625502e02776943
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Jul 15 13:51:22 2016 +0300

    intel/x4x: Do not use scratchpad register for ACPI S3
    
    If S3 support was implemented for this platform later on, use
    romstage handoff structure instead.
    
    Change-Id: I03c1e07a7fcc17c27203d0c4e32e3958f2ba5273
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/northbridge/intel/x4x/northbridge.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/src/northbridge/intel/x4x/northbridge.c b/src/northbridge/intel/x4x/northbridge.c
index 2d6c39f..15e150e 100644
--- a/src/northbridge/intel/x4x/northbridge.c
+++ b/src/northbridge/intel/x4x/northbridge.c
@@ -162,22 +162,6 @@ static void enable_dev(device_t dev)
 	/* Set the operations if it is a special bus type */
 	if (dev->path.type == DEVICE_PATH_DOMAIN) {
 		dev->ops = &pci_domain_ops;
-#if CONFIG_HAVE_ACPI_RESUME
-		switch (pci_read_config32(dev_find_slot(0, PCI_DEVFN(0, 0)), /*D0F0_SKPD*/0xdc)) {
-		case SKPAD_NORMAL_BOOT_MAGIC:
-			printk(BIOS_DEBUG, "Normal boot.\n");
-			acpi_slp_type=0;
-			break;
-		case SKPAD_ACPI_S3_MAGIC:
-			printk(BIOS_DEBUG, "S3 Resume.\n");
-			acpi_slp_type=3;
-			break;
-		default:
-			printk(BIOS_DEBUG, "Unknown boot method, assuming normal.\n");
-			acpi_slp_type=0;
-			break;
-		}
-#endif
 	} else if (dev->path.type == DEVICE_PATH_CPU_CLUSTER) {
 		dev->ops = &cpu_bus_ops;
 	}