[coreboot-gerrit] New patch to review for coreboot: skylake: Move CHROMEOS config to SoC
Furquan Shaikh (furquan@google.com)
gerrit at coreboot.org
Sun Jul 24 03:47:30 CEST 2016
Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15822
-gerrit
commit 9436ec8cb71c9804745762b54f6eb707d740bbb6
Author: Furquan Shaikh <furquan at google.com>
Date: Fri Jul 22 16:17:53 2016 -0700
skylake: Move CHROMEOS config to SoC
All the mainboards share the same config options for CHROMEOS. Instead
of duplicating those in every mainboard, move the CHROMEOS config to SoC
and make it dependent on MAINBOARD_HAS_CHROMEOS.
BUG=chrome-os-partner:55431
Change-Id: Iafabb6373dfe16aaf0fe2cbc4e978952adeb403e
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
src/mainboard/google/chell/Kconfig | 10 ----------
src/mainboard/google/glados/Kconfig | 10 ----------
src/mainboard/google/lars/Kconfig | 10 ----------
src/mainboard/intel/kunimitsu/Kconfig | 10 ----------
src/soc/intel/skylake/Kconfig | 11 +++++++++++
5 files changed, 11 insertions(+), 40 deletions(-)
diff --git a/src/mainboard/google/chell/Kconfig b/src/mainboard/google/chell/Kconfig
index 95102b6..d7c175c 100644
--- a/src/mainboard/google/chell/Kconfig
+++ b/src/mainboard/google/chell/Kconfig
@@ -19,16 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select MONOTONIC_TIMER_MSR
select SOC_INTEL_SKYLAKE
-config CHROMEOS
- select CHROMEOS_RAMOOPS_DYNAMIC
- select CHROMEOS_VBNV_CMOS
- select CHROMEOS_VBNV_CMOS_BACKUP_TO_FLASH
- select EC_SOFTWARE_SYNC
- select LID_SWITCH
- select VBOOT_EC_SLOW_UPDATE
- select VBOOT_OPROM_MATTERS
- select VIRTUAL_DEV_SWITCH
-
config DRIVERS_I2C_GENERIC
def_bool y
diff --git a/src/mainboard/google/glados/Kconfig b/src/mainboard/google/glados/Kconfig
index abe5fa8..cca4f32 100644
--- a/src/mainboard/google/glados/Kconfig
+++ b/src/mainboard/google/glados/Kconfig
@@ -19,16 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select MONOTONIC_TIMER_MSR
select SOC_INTEL_SKYLAKE
-config CHROMEOS
- select CHROMEOS_RAMOOPS_DYNAMIC
- select CHROMEOS_VBNV_CMOS
- select CHROMEOS_VBNV_CMOS_BACKUP_TO_FLASH
- select EC_SOFTWARE_SYNC
- select LID_SWITCH
- select VBOOT_EC_SLOW_UPDATE
- select VBOOT_OPROM_MATTERS
- select VIRTUAL_DEV_SWITCH
-
config DRIVERS_I2C_GENERIC
def_bool y
diff --git a/src/mainboard/google/lars/Kconfig b/src/mainboard/google/lars/Kconfig
index ee08067..d891fbd 100644
--- a/src/mainboard/google/lars/Kconfig
+++ b/src/mainboard/google/lars/Kconfig
@@ -20,16 +20,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select MONOTONIC_TIMER_MSR
select SOC_INTEL_SKYLAKE
-config CHROMEOS
- select CHROMEOS_RAMOOPS_DYNAMIC
- select CHROMEOS_VBNV_CMOS
- select CHROMEOS_VBNV_CMOS_BACKUP_TO_FLASH
- select LID_SWITCH
- select VBOOT_EC_SLOW_UPDATE
- select VBOOT_OPROM_MATTERS
- select VIRTUAL_DEV_SWITCH
- select EC_SOFTWARE_SYNC
-
config DRIVERS_GENERIC_MAX98357A
default y
diff --git a/src/mainboard/intel/kunimitsu/Kconfig b/src/mainboard/intel/kunimitsu/Kconfig
index 85b568e..4aecc90 100644
--- a/src/mainboard/intel/kunimitsu/Kconfig
+++ b/src/mainboard/intel/kunimitsu/Kconfig
@@ -19,16 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select MONOTONIC_TIMER_MSR
select SOC_INTEL_SKYLAKE
-config CHROMEOS
- select CHROMEOS_RAMOOPS_DYNAMIC
- select CHROMEOS_VBNV_CMOS
- select CHROMEOS_VBNV_CMOS_BACKUP_TO_FLASH
- select LID_SWITCH
- select VBOOT_EC_SLOW_UPDATE
- select VBOOT_OPROM_MATTERS
- select VIRTUAL_DEV_SWITCH
- select EC_SOFTWARE_SYNC
-
config DRIVERS_GENERIC_MAX98357A
default y
diff --git a/src/soc/intel/skylake/Kconfig b/src/soc/intel/skylake/Kconfig
index 0871ed0..6d65ad5 100644
--- a/src/soc/intel/skylake/Kconfig
+++ b/src/soc/intel/skylake/Kconfig
@@ -51,6 +51,17 @@ config CPU_SPECIFIC_OPTIONS
select UDELAY_TSC
select USE_GENERIC_FSP_CAR_INC
+config CHROMEOS
+ depends on MAINBOARD_HAS_CHROMEOS
+ select CHROMEOS_RAMOOPS_DYNAMIC
+ select CHROMEOS_VBNV_CMOS
+ select CHROMEOS_VBNV_CMOS_BACKUP_TO_FLASH
+ select EC_SOFTWARE_SYNC
+ select LID_SWITCH
+ select VBOOT_EC_SLOW_UPDATE
+ select VBOOT_OPROM_MATTERS
+ select VIRTUAL_DEV_SWITCH
+
config BOOTBLOCK_CPU_INIT
string
default "soc/intel/skylake/bootblock/cpu.c"
More information about the coreboot-gerrit
mailing list